Update Python Wheel File Path#7978
Merged
Merged
Conversation
jywu-msft
reviewed
Jun 7, 2021
| -e BUILD_BUILDNUMBER \ | ||
| onnxruntimecpubuild \ | ||
| bash -c " $(PythonManylinuxDir)/bin/python3 -m pip install /build/Release/dist/onnxruntime*.whl && /onnxruntime_src/tools/doc/builddoc.sh $(PythonManylinuxDir)/bin/ /onnxruntime_src /build Release " ; | ||
| bash -c " $(PythonManylinuxDir)/bin/python3 -m pip install /build/Release/dist/*.whl && /onnxruntime_src/tools/doc/builddoc.sh $(PythonManylinuxDir)/bin/ /onnxruntime_src /build Release " ; |
Member
There was a problem hiding this comment.
just to confirm. this change is needed because the nightly packages are named ort-nightly* ?
Contributor
Author
There was a problem hiding this comment.
Right, when the pipeline variable ORT_NIGHTLY=0 (which is what we use to test, and what I did here) the wheel file name is onnxruntime*.whl. When ORT_NIGHTLY=1 the filename is ort-nightly*.whl. I kept the naming consistent with the rest of the file which writes Release/dist/*.whl I think for this reason.
jywu-msft
approved these changes
Jun 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Change file path to locate wheel file to make Python Packaging Pipeline pass.
Motivation and Context