Skip to content

Fix Python Packaging Pipeline && Build Clean Up#7993

Merged
pengwa merged 9 commits intomasterfrom
pengwa/fix_build
Jun 9, 2021
Merged

Fix Python Packaging Pipeline && Build Clean Up#7993
pengwa merged 9 commits intomasterfrom
pengwa/fix_build

Conversation

@pengwa
Copy link
Copy Markdown
Contributor

@pengwa pengwa commented Jun 8, 2021 •
edited
Loading

Description: Fix Python Packaging Pipeline && Build clean up

  • Fix Build Break for "Python Packaging Pipeline (Training Cuda 11.1)", disable the torch interop feature, to unblock the pipeline first. Will continue refining the builds afterwards.
  • Previous autograd PR introduced python dependency. While link to python so in most cases are not necessary, so we did refinement here.

Motivation and Context

  • Why is this change required? What problem does it solve?
  • If it fixes an open issue, please link to the issue here.

@pengwa pengwa requested a review from a team as a code owner June 8, 2021 15:46
@pengwa pengwa changed the title remove python so link Fix Remove python so link Jun 8, 2021
@pengwa pengwa changed the title Fix Remove python so link Fix Python Packaging Pipeline && Build Clean Up Jun 8, 2021
@pengwa pengwa requested review from snnn and wschin June 8, 2021 17:45
@pengwa pengwa added core runtime issues related to core runtime component:ortmodule training issues related to ONNX Runtime training; typically submitted using template labels Jun 8, 2021
wschin
wschin reviewed Jun 9, 2021
View reviewed changes
wschin
wschin previously approved these changes Jun 9, 2021
View reviewed changes
snnn
snnn reviewed Jun 9, 2021
View reviewed changes
snnn
snnn reviewed Jun 9, 2021
View reviewed changes
@pengwa pengwa mentioned this pull request Jun 9, 2021
Merged
@pengwa
Copy link
Copy Markdown
Contributor Author

pengwa commented Jun 9, 2021

Thanks @snnn and @wschin .

@pengwa pengwa merged commit cb5f411 into master Jun 9, 2021
@pengwa pengwa deleted the pengwa/fix_build branch June 9, 2021 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@snnn snnn snnn approved these changes

@wschin wschin wschin left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

core runtime issues related to core runtime training issues related to ONNX Runtime training; typically submitted using template

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pengwa @snnn @wschin