Skip to content

[NNAPI EP] Enable Slice support#8031

Merged
guoyu-wang merged 4 commits intomasterfrom
gwang-msft/nnapi_ep_slice
Jun 17, 2021
Merged

[NNAPI EP] Enable Slice support#8031
guoyu-wang merged 4 commits intomasterfrom
gwang-msft/nnapi_ep_slice

Conversation

@guoyu-wang
Copy link
Copy Markdown
Contributor

@guoyu-wang guoyu-wang commented Jun 11, 2021

Description: [NNAPI EP] Enable Slice support

Motivation and Context

  • Enabled slice support which is part of SSD models
  • Moved the shape inference functions from CPU slice impl to 2 separated helper files, which can be shared without including certain dependencies of CPU EP such as eigen
  • Added ends_ field for SliceOp::PrepareForComputeMetadata
  • Updated UT

@guoyu-wang guoyu-wang requested a review from a team as a code owner June 11, 2021 06:08
@edgchen1
Copy link
Copy Markdown
Contributor

edgchen1 commented Jun 16, 2021

const T& clamp(const T& v, const T& lo, const T& hi) {

is this still needed in this file?


In reply to: 861976198


Refers to: onnxruntime/core/providers/cpu/tensor/slice.cc:51 in a6155a4. [](commit_id = a6155a4, deletion_comment = False)

@guoyu-wang
Copy link
Copy Markdown
Contributor Author

guoyu-wang commented Jun 16, 2021

const T& clamp(const T& v, const T& lo, const T& hi) {

is this still needed in this file?

Refers to: onnxruntime/core/providers/cpu/tensor/slice.cc:51 in a6155a4. [](commit_id = a6155a4, deletion_comment = False)

Removed


In reply to: 862004431

Copy link
Copy Markdown
Contributor

@edgchen1 edgchen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@guoyu-wang guoyu-wang merged commit d83f7fd into master Jun 17, 2021
@guoyu-wang guoyu-wang deleted the gwang-msft/nnapi_ep_slice branch June 17, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants