Merged
Conversation
nkreeger
approved these changes
Jun 27, 2021
|
|
||
| cudnnPoolingMode_t mode = CUDNN_POOLING_MAX; | ||
| if (PoolType::type == onnxruntime::PoolType::kAveragePool) { | ||
| if constexpr (PoolType::type == onnxruntime::PoolType::kAveragePool) { |
Member
There was a problem hiding this comment.
Why not ORT_IF_CONSTEXPR ?
Contributor
Author
There was a problem hiding this comment.
It's a cc file. ORT_IF_CONSTEXPR is for header files that are also used in *.cu files. This file is compiled by GCC which can support C++17 well. The main limitation comes from nvcc, which compiles *.cu files.
Contributor
Author
There was a problem hiding this comment.
But, we can use ORT_IF_CONSTEXPR in all the places. Was that your question?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The warning is:
"Potential comparison of a constant with another constant. at D:\a_work\1\s\onnxruntime\core\providers\cuda\nn\pool.cc@167,21".
It was found by VS static code analyzer in our CUDA EP.
Motivation and Context
This change is related to #8041. Because we are in C++17 now, we should use "if constexpr" when applicable.