Skip to content

reformat build suffix so that the latest is always correct#8267

Merged
liqunfu merged 8 commits intomasterfrom
liqun/build_numer_2_digits
Aug 6, 2021
Merged

reformat build suffix so that the latest is always correct#8267
liqunfu merged 8 commits intomasterfrom
liqun/build_numer_2_digits

Conversation

@liqunfu
Copy link
Contributor

@liqunfu liqunfu commented Jul 1, 2021

Description:

we want to format the build_suffix to avoid (the 12th run on 20210630 vs the first run on 20210701):

    # 2021063012 > 20210701
    # in above 2021063012 is treated as the latest which is incorrect.
    # we want to convert the format to:
    # 20210630012 < 20210701001
    # where the first 8 digits are date. the last 3 digits are run count.
    # as long as there are less than 1000 runs per day, we will not have the problem.

@liqunfu liqunfu requested a review from a team as a code owner July 1, 2021 04:17
thiagocrepaldi
thiagocrepaldi previously approved these changes Aug 5, 2021
Copy link
Contributor

@suffiank suffiank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! This is needed.

@liqunfu liqunfu merged commit 419fd5c into master Aug 6, 2021
@liqunfu liqunfu deleted the liqun/build_numer_2_digits branch August 6, 2021 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants