Skip to content

Move the samples to a new repo#8374

Merged
snnn merged 5 commits intomasterfrom
snnn/move_samples
Jul 14, 2021
Merged

Move the samples to a new repo#8374
snnn merged 5 commits intomasterfrom
snnn/move_samples

Conversation

@snnn
Copy link
Copy Markdown
Contributor

@snnn snnn commented Jul 13, 2021

Description:

Move the samples to a new repo https://github.com/microsoft/onnxruntime-inference-examples

Motivation and Context

  • Why is this change required? What problem does it solve?

To organize them better and setup build pipelines for them.

Also, it would be easier for us to manage open source usage registrations. Samples typically use 3rd party libraries much more. I don't want to mix them with the main library. Like, I don't want to put tensorflow into https://github.com/microsoft/onnxruntime/blob/master/ThirdPartyNotices.txt just because an ONNX Runtime sample uses it. It would confuse people who just want to import the main onnxruntime library.

  • If it fixes an open issue, please link to the issue here.

Related PR: microsoft/onnxruntime-inference-examples#12

Copy link
Copy Markdown
Contributor

@thiagocrepaldi thiagocrepaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would create a folder that indicates the type of sample, such as samples/training/ortmodule/nodejs, samples/training/training/orttrainer/nodejs, samples/inference

This way we can properly set code owners without conflicts

@snnn
Copy link
Copy Markdown
Contributor Author

snnn commented Jul 13, 2021

I would create a folder that indicates the type of sample, such as samples/training/ortmodule/nodejs, samples/training/training/orttrainer/nodejs, samples/inference

This way we can properly set code owners without conflicts

Training samples should go to https://github.com/microsoft/onnxruntime-training-examples. Does this folder have training samples?

In the new repo I will follow your advice and setup code owners. For example, iOS to the mobile team and c_cxx to the people under Pranav.

Changming Sun added 2 commits July 13, 2021 13:05
@snnn
Copy link
Copy Markdown
Contributor Author

snnn commented Jul 13, 2021

I found one: samples/python/pytorch_transformer. It is for training.

@snnn
Copy link
Copy Markdown
Contributor Author

snnn commented Jul 14, 2021

Another one: samples/python/mnist

@snnn
Copy link
Copy Markdown
Contributor Author

snnn commented Jul 14, 2021

Related PR: #8335 . Sherlock is moving the training samples to training dir.

@thiagocrepaldi
Copy link
Copy Markdown
Contributor

I would create a folder that indicates the type of sample, such as samples/training/ortmodule/nodejs, samples/training/training/orttrainer/nodejs, samples/inference
This way we can properly set code owners without conflicts

Training samples should go to https://github.com/microsoft/onnxruntime-training-examples. Does this folder have training samples?

In the new repo I will follow your advice and setup code owners. For example, iOS to the mobile team and c_cxx to the people under Pranav.

There are 2 for ORTTrainer pytorch forntend: python/mnist and python/pytorch_transformer. They are used for some end-to-end test

@snnn
Copy link
Copy Markdown
Contributor Author

snnn commented Jul 14, 2021

Thank you @thiagocrepaldi , I excluded them from this PR and kept them untouched.

@snnn snnn requested a review from thiagocrepaldi July 14, 2021 16:34
Copy link
Copy Markdown
Contributor

@thiagocrepaldi thiagocrepaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check with quantization team about this removal. They often check in stuff to the samples folder

@snnn snnn requested a review from yufenglee July 14, 2021 16:57
Copy link
Copy Markdown
Member

@yufenglee yufenglee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@snnn snnn merged commit 4e1c5f6 into master Jul 14, 2021
@snnn snnn deleted the snnn/move_samples branch July 14, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants