decouple pytorch from onnxruntime training build#8815
Merged
Conversation
snnn
previously approved these changes
Aug 23, 2021
Contributor
|
There is another one at: https://github.com/microsoft/onnxruntime/blob/master/tools/ci_build/github/linux/docker/scripts/manylinux/install_deps.sh#L96 Do you need it? |
thiagocrepaldi
approved these changes
Aug 24, 2021
Contributor
Author
@snnn, manylinux/install_deps.sh is referred by many docker files and scripted. This PR shall not have impact on it. |
snnn
approved these changes
Aug 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: onnxruntime-training does not depend on torch version. so remove torch version from training packages. We still test onnxruntime training packages against many torch versions when building training packages.