Skip to content

Stop gradient for Multinomial, RandomNormalLike, RandomUniformLike and EyeLike#8836

Merged
SherlockNoMad merged 2 commits intomasterfrom
bahuang/stop_grad
Aug 28, 2021
Merged

Stop gradient for Multinomial, RandomNormalLike, RandomUniformLike and EyeLike#8836
SherlockNoMad merged 2 commits intomasterfrom
bahuang/stop_grad

Conversation

@SherlockNoMad
Copy link
Copy Markdown
Contributor

Multinomial, RandomNormalLike, RandomUniformLike and EyeLike are generator ops, and thus not differentialable.

@SherlockNoMad SherlockNoMad added the training issues related to ONNX Runtime training; typically submitted using template label Aug 24, 2021
@SherlockNoMad SherlockNoMad requested a review from a team as a code owner August 24, 2021 21:48
Copy link
Copy Markdown
Contributor

@jingyanwangms jingyanwangms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this change on a 2 week old branch. Pretrain doesn't work with branch due to suspected exporter regression (item 1340738). @SherlockNoMad can you please keep this branch around after merge for above exporter regression investigation? Thank you

@SherlockNoMad SherlockNoMad merged commit 6e20eb7 into master Aug 28, 2021
@SherlockNoMad SherlockNoMad deleted the bahuang/stop_grad branch August 28, 2021 23:21
@SherlockNoMad SherlockNoMad restored the bahuang/stop_grad branch August 28, 2021 23:21
@SherlockNoMad SherlockNoMad deleted the bahuang/stop_grad branch October 21, 2021 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

training issues related to ONNX Runtime training; typically submitted using template

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants