Fix cast propagation to not change casts from bool type.#8925
Merged
satyajandhyala merged 2 commits intomasterfrom Sep 1, 2021
Merged
Fix cast propagation to not change casts from bool type.#8925satyajandhyala merged 2 commits intomasterfrom
satyajandhyala merged 2 commits intomasterfrom
Conversation
satyajandhyala
added
component:ortmodule
training
SherlockNoMad
approved these changes
Sep 1, 2021
satyajandhyala
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Describe your changes.
Cast propagation transformation should not touch cast from bool -> float or bool->float16. Doing so would lead to type mismatch errors.
Motivation and Context