Skip to content

Added code to support Softmaxgrad for DNNL EP#9022

Merged
jywu-msft merged 2 commits into
microsoft:masterfrom
chethanpk:cpalango/dnnl_softmaxgrad
Sep 22, 2021
Merged

Added code to support Softmaxgrad for DNNL EP#9022
jywu-msft merged 2 commits into
microsoft:masterfrom
chethanpk:cpalango/dnnl_softmaxgrad

Conversation

@chethanpk
Copy link
Copy Markdown
Contributor

@chethanpk chethanpk commented Sep 9, 2021

Signed-off-by: Chethan Palangotu Keshava chethan.palangotu.keshava@intel.com

Description: Added code to support Softmaxgrad operator for the DNNL EP and broadened the support of softmax.

Motivation and Context
Necessary operator for complete execution of transformer model graphs.

Signed-off-by: Chethan Palangotu Keshava <chethan.palangotu.keshava@intel.com>
@georgen117
Copy link
Copy Markdown
Contributor

maintainer please remember to run /azp run Linux DNNL CI Pipeline since this is the main pipeline that runs the dnnl ep.

@chethanpk chethanpk changed the title Added code to support Softmaxgrad Added code to support Softmaxgrad for DNNL EP Sep 10, 2021
@jywu-msft
Copy link
Copy Markdown
Member

/azp run Linux DNNL CI Pipeline

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@chethanpk
Copy link
Copy Markdown
Contributor Author

I am looking into the failure. I had disabled a few checks in softmax, which I feel is causing this model failure.

This will fix the test failures from onnnx repo.

Signed-off-by: Chethan Palangotu Keshava <chethan.palangotu.keshava@intel.com>
@chethanpk
Copy link
Copy Markdown
Contributor Author

/azp run Linux DNNL CI Pipeline

Can you please run this again? I have pushed a fix for these failures.

@jywu-msft
Copy link
Copy Markdown
Member

/azp run Linux DNNL CI Pipeline

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@jywu-msft
Copy link
Copy Markdown
Member

/azp run MacOS NoContribops CI Pipeline, Windows CPU CI Pipeline, Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, Windows WebAssembly CI Pipeline, orttraining-amd-gpu-ci-pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-ortmodule-distributed

@jywu-msft
Copy link
Copy Markdown
Member

/azp run Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux CPU x64 NoContribops CI Pipeline, Linux CPU x64 NoContribops CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux Nuphar CI Pipeline, Linux OpenVINO CI Pipeline, MacOS CI Pipeline

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 8 pipeline(s).

1 similar comment
@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 8 pipeline(s).

@jywu-msft
Copy link
Copy Markdown
Member

/azp run onnxruntime-python-checks-ci-pipeline

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@jywu-msft jywu-msft merged commit 267fb89 into microsoft:master Sep 22, 2021
@chethanpk chethanpk deleted the cpalango/dnnl_softmaxgrad branch September 23, 2021 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants