Fix a bug for Openvino Python binding#9130
Merged
pranavsharma merged 1 commit intomasterfrom Sep 21, 2021
Merged
Conversation
snnn
added
ep:OpenVINO
pranavsharma
approved these changes
Sep 21, 2021
Contributor
There was a problem hiding this comment.
None of our tests caught this. We should add a test for this later. @souptc
We should also add a windows pipeline for openvino. @jywu-msft
Contributor
Author
|
We can catch the same error on Linux. But we disabled too many warnings in Linux build. If we do the same thing for Windows, we won't be able to see the same error either. So I think it is not because we don't have enough number of build pipelines. More is always better. But the fundamental problem is enabling the warnings. |
wangyems
added a commit
that referenced
this pull request
Sep 21, 2021
* Fixing MORE mlas unittest failures in POWER (#8673) * Ensure ms-experimental domain Audio Ops build in mac pipeline (#8857) * Globally enable ms-experimental ops * change meaning of ms_experimental to mean *all* ms_experimental ops. Some experimental ops will still be enabled globally without this flag like audio ops. * add cmath * add cmath to signal_defs.cc * move audio back into experimental, verify on mac * remove experimental from mac builds Co-authored-by: Sheil Kumar <sheilk@microsoft.com> * Remove cpuinfo from WCOS builds (#9076) * Fix a bug for Openvino Python binding (#9130) * Fix default initialization value in C API header (#9126) * fix default initialization value in C API header * Fix conflicts * Nits * Do not generate nuget symbol packages on Linux * fix name conflict in 1.9 for Fix default initialization value in C API header * Fix nightly CI pipeline to generate ROCm 4.2 wheels and add ROCm 4.3.1 wheels (#9101) * make work for both rocm 4.2 and rocm 4.3.1 * fix rocm 4.3.1 docker image reference * fix CUDA_VERSION to ROCM_VERSION * fix ReduceConsts conflict def * add ifdef to miopen_common.h as well * trailing ws * remove OrtCUDAProviderOptions() and simply set value * revert to use custom ctor and fix tests Co-authored-by: austinpagan <fossum@us.ibm.com> Co-authored-by: Sheil Kumar <smk2007@gmail.com> Co-authored-by: Sheil Kumar <sheilk@microsoft.com> Co-authored-by: Tiago Koji Castro Shibata <ticastro@microsoft.com> Co-authored-by: Changming Sun <chasun@microsoft.com> Co-authored-by: Hariharan Seshadri <shariharan91@gmail.com> Co-authored-by: Suffian Khan <sukha@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fix a bug for Openvino Python binding
Motivation and Context
Resolve [OpenVINO-EP] Windows Build broken for Debug Mode #9122