Merged
Conversation
satyajandhyala
added
component:ortmodule
training
satyajandhyala
force-pushed
the
sajandhy/add_tanh_grad
branch
2 times, most recently
from
6e4615e to
215aad6
Compare
satyajandhyala
force-pushed
the
sajandhy/add_tanh_grad
branch
from
215aad6 to
3dbc993
Compare
orttraining/orttraining/test/python/orttraining_test_ortmodule_api.py
Outdated
Show resolved
Hide resolved
orttraining/orttraining/test/python/orttraining_test_ortmodule_api.py
Outdated
Show resolved
Hide resolved
SherlockNoMad
previously approved these changes
Oct 25, 2021
Contributor
SherlockNoMad
left a comment
SherlockNoMad
left a comment
There was a problem hiding this comment.
LGTM with nit comments.
Contributor
Author
|
Using the new TanhGrad operator reduced the gradient computation from (36.5+21.5) 58 microseconds to 21 microseconds. The perf improvement is about 30%. |
satyajandhyala
requested review from
YUNQIUGUO,
baijumeswani,
edgchen1,
guoyu-wang,
liqunfu,
skottmckay,
thiagocrepaldi,
tlh20 and
xadupre
as code owners
SherlockNoMad
approved these changes
Oct 26, 2021
edgchen1
approved these changes
Oct 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Added Tanh gradient schema and kernel
Motivation and Context