Weaken x86.get_pc_thunk for NDK <= r22#9994
Merged
Conversation
Otherwise there is multiple definition of '__x86.get_pc_thunk.bx'
yihonglyu
requested review from
chenfucn,
snnn,
tracysh,
yufenglee and
zhanghuanrong
yufenglee
approved these changes
Dec 9, 2021
guoyu-wang
approved these changes
Dec 10, 2021
Contributor
guoyu-wang
left a comment
guoyu-wang
left a comment
There was a problem hiding this comment.
Please trigger a run on this pipeline https://aiinfra.visualstudio.com/Lotus/_build?definitionId=940&_a=summary and try compile with NDK 23 also
Thanks
Contributor
Author
https://aiinfra.visualstudio.com/Lotus/_build/results?buildId=186237&view=logs&j=1d5006dc-97a7-5b41-9d44-41bfffdb2d83 is passed. I compile ONNX Runtime locally with NDK 23 and it is passed as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise multiple definition of '__x86.get_pc_thunk.bx' would cause error.