-
Notifications
You must be signed in to change notification settings - Fork 86
Add Op(built-in function ops) | feat(torchlib) #1135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Op(built-in function ops) | feat(torchlib) #1135
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1135 +/- ##
==========================================
- Coverage 78.40% 78.39% -0.02%
==========================================
Files 118 118
Lines 15046 15054 +8
Branches 1604 1604
==========================================
+ Hits 11797 11801 +4
- Misses 2878 2882 +4
Partials 371 371
|
LGTM. Cc @BowenBao for namespace naming conventions |
I am thinking something like python.operator and python.math may be more principled |
A different domain from DOMAIN = "pkg.onnxscript.torch_lib"? I don't know if we should mark the difference in the graph, as they are the same (eg: operator.add and aten::add) in ONNX perspective. |
I meant |
In that case, string processing would need to live somewhere in torchlib registration or converter registration to match _operator.add (original name). |
SG. That's a good argument to keep the existing names |
…-onnx exporter" Fix microsoft/onnx-converters-private#190 This PR retires built-in function mapping by adding built-in ops into torchlib (microsoft/onnxscript#1135), and provide a runtime tests to guard the operation conversion. More built-in ops are supported in torchlib as well. [ghstack-poisoned]
Fix microsoft/onnx-converters-private#190 This PR retires built-in function mapping by adding built-in ops into torchlib (microsoft/onnxscript#1135), and provide a runtime tests to guard the operation conversion. More built-in ops are supported in torchlib as well. [ghstack-poisoned]
…-onnx exporter" Fix microsoft/onnx-converters-private#190 This PR retires built-in function mapping by adding built-in ops into torchlib (microsoft/onnxscript#1135), and provide a runtime tests to guard the operation conversion. More built-in ops are supported in torchlib as well. [ghstack-poisoned]
Fix microsoft/onnx-converters-private#190 This PR retires built-in function mapping by adding built-in ops into torchlib (microsoft/onnxscript#1135), and provide a runtime tests to guard the operation conversion. More built-in ops are supported in torchlib as well. [ghstack-poisoned]
…-onnx exporter" Fix microsoft/onnx-converters-private#190 This PR retires built-in function mapping by adding built-in ops into torchlib (microsoft/onnxscript#1135), and provide a runtime tests to guard the operation conversion. More built-in ops are supported in torchlib as well. [ghstack-poisoned]
Fix microsoft/onnx-converters-private#190 This PR retires built-in function mapping by adding built-in ops into torchlib (microsoft/onnxscript#1135), and provide a runtime tests to guard the operation conversion. More built-in ops are supported in torchlib as well. [ghstack-poisoned]
…-onnx exporter" Fix microsoft/onnx-converters-private#190 This PR retires built-in function mapping by adding built-in ops into torchlib (microsoft/onnxscript#1135), and provide a runtime tests to guard the operation conversion. More built-in ops are supported in torchlib as well. [ghstack-poisoned]
Fix microsoft/onnx-converters-private#190 This PR retires built-in function mapping by adding built-in ops into torchlib (microsoft/onnxscript#1135), and provide a runtime tests to guard the operation conversion. More built-in ops are supported in torchlib as well. [ghstack-poisoned]
…-onnx exporter" Fix microsoft/onnx-converters-private#190 This PR retires built-in function mapping by adding built-in ops into torchlib (microsoft/onnxscript#1135), and provide a runtime tests to guard the operation conversion. More built-in ops are supported in torchlib as well. NOTE: `native_batch_norm` regression is caused by microsoft/onnxscript#1140. Will fix it before I merge this. [ghstack-poisoned]
Fix microsoft/onnx-converters-private#190 This PR retires built-in function mapping by adding built-in ops into torchlib (microsoft/onnxscript#1135), and provide a runtime tests to guard the operation conversion. More built-in ops are supported in torchlib as well. NOTE: `native_batch_norm` regression is caused by microsoft/onnxscript#1140. Will fix it before I merge this. [ghstack-poisoned]
…-onnx exporter" Fix microsoft/onnx-converters-private#190 This PR retires built-in function mapping by adding built-in ops into torchlib (microsoft/onnxscript#1135), and provide a runtime tests to guard the operation conversion. More built-in ops are supported in torchlib as well. ~~NOTE: `native_batch_norm` regression is caused by microsoft/onnxscript#1140. Will fix it before I merge this.~~ [ghstack-poisoned]
Fix microsoft/onnx-converters-private#190 This PR retires built-in function mapping by adding built-in ops into torchlib (microsoft/onnxscript#1135), and provide a runtime tests to guard the operation conversion. More built-in ops are supported in torchlib as well. ~~NOTE: `native_batch_norm` regression is caused by microsoft/onnxscript#1140. Will fix it before I merge this.~~ [ghstack-poisoned]
…-onnx exporter" Fix microsoft/onnx-converters-private#190 This PR retires built-in function mapping by adding built-in ops into torchlib (microsoft/onnxscript#1135), and provide a runtime tests to guard the operation conversion. More built-in ops are supported in torchlib as well. ~~NOTE: `native_batch_norm` regression is caused by microsoft/onnxscript#1140. Will fix it before I merge this.~~ [ghstack-poisoned]
Fix microsoft/onnx-converters-private#190 This PR retires built-in function mapping by adding built-in ops into torchlib (microsoft/onnxscript#1135), and provide a runtime tests to guard the operation conversion. More built-in ops are supported in torchlib as well. ~~NOTE: `native_batch_norm` regression is caused by microsoft/onnxscript#1140. Will fix it before I merge this.~~ [ghstack-poisoned]
Fix https://github.com/microsoft/onnx-converters-private/issues/190 This PR retires built-in function mapping by adding built-in ops into torchlib (microsoft/onnxscript#1135), and provide a runtime tests to guard the operation conversion. More built-in ops are supported in torchlib as well. ~~NOTE: `native_batch_norm` regression is caused by microsoft/onnxscript#1140. Will fix it before I merge this.~~ Pull Request resolved: #112758 Approved by: https://github.com/justinchuby, https://github.com/thiagocrepaldi
) Fix https://github.com/microsoft/onnx-converters-private/issues/190 This PR retires built-in function mapping by adding built-in ops into torchlib (microsoft/onnxscript#1135), and provide a runtime tests to guard the operation conversion. More built-in ops are supported in torchlib as well. ~~NOTE: `native_batch_norm` regression is caused by microsoft/onnxscript#1140. Will fix it before I merge this.~~ Pull Request resolved: pytorch#112758 Approved by: https://github.com/justinchuby, https://github.com/thiagocrepaldi
Fix https://github.com/microsoft/onnx-converters-private/issues/190
With pytorch/pytorch#112758, this PR moves built-in function ops mapping into torchlib.
NOTE: module name of
operator.add
is _operator