IR-based inliner #1829
IR-based inliner #1829
Conversation
Signed-off-by: Ganesan Ramalingam <grama@microsoft.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
❌ 4 Tests Failed:
View the top 3 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
Test Results 24 files ± 0 24 suites ±0 2h 50m 47s ⏱️ +13s For more details on these failures and errors, see this check. Results for commit dca5d9c. ± Comparison against base commit 74ae4cc. This pull request skips 1 test.♻️ This comment has been updated with latest results. |
… into rama/inliner
|
Just checking: will the meta data from the function call node be added to the inlined nodes? That would be desirable. |
Hmmm. Yes, that would be useful. What would we do in the case of conflicts, though? (Same question comes up for rewriter, would be nice to have a common solution, if possible.) |
|
In the torch exporter's case, since only nodes from the main graph have metadata written to them, taking the metadata from the main node is the most useful. |
|
Added merging of metadata props |
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com>
…into rama/inliner
justinchuby
left a comment
justinchuby
left a comment
There was a problem hiding this comment.
Maybe functions cannot have initialized values, so const_values are irrelevant after all?
Add utility to inline all functions in a model.
Still TODO:
Fixes #1769