Skip to content

Check inputs num for node matching #1885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 9, 2024
Merged

Check inputs num for node matching #1885

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c60d048
Check inputs num for node matching
Sep 27, 2024
07bad1e
Add comment
Oct 8, 2024
4419f27
Fix lint errors
Oct 9, 2024
3aaa866
Update onnxscript/rewriter/pattern.py
justinchuby Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions onnxscript/rewriter/pattern.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -959,6 +959,12 @@ def _match_node(self, pattern_node: NodePattern, node: ir.Node) -> bool:

self._matched[pattern_node] = node

# TODO: Revisit this to handle optional trailing inputs better.
if len(node.inputs) != len(pattern_node.inputs):
return self.fail(
"Input nums mismatch. {len(node.inputs)} vs {len(pattern_node.inputs)}"
)

for arg_value, arg_pattern in zip(node.inputs, pattern_node.inputs):
# arg_pattern could be a Var, if it's the original arg.
if arg_pattern is None:
Expand Down