Bump numpy to 1.22.0 #289
Merged
Bump numpy to 1.22.0 #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #289 +/- ##
==========================================
+ Coverage 72.73% 72.87% +0.13%
==========================================
Files 95 96 +1
Lines 9176 9186 +10
==========================================
+ Hits 6674 6694 +20
+ Misses 2502 2492 -10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
justinchuby
approved these changes
Jan 6, 2023
|
Looks like this bump may leave behind Python 3.7 support... let's hold on this. |
jcwchen
reviewed
Jan 9, 2023
|
Per discussion this morning we're going to drop support for 3.7 as it EOLs in June anyway, so I will update this PR to do that as well. |
justinchuby
added a commit
that referenced
this pull request
Jan 9, 2023
PyTorch can supply int32 inputs as SymInt values. This change adds explicit casts to them to fix the Windows CI. Fixed additional mypy errors #289 may be needed for python3.10
abock
force-pushed
the
abock/numpy-1.22.0
branch
from
c978bec to
d0f5a55
Compare
abock
force-pushed
the
abock/numpy-1.22.0
branch
from
d0f5a55 to
b6c256b
Compare
|
Oh man, this had the very unfortunate side effect of breaking Onnx builds on PyTorch. (It uses this script to install Onnx, and still supports python 3.7) https://github.com/pytorch/pytorch/actions/runs/3878248792/jobs/6614365795 |
|
Should we pin a commit in PyTorch for now? |
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Jan 10, 2023
Onnx PR microsoft/onnxscript#289 expects numpy to be upgraded. That breaks pytorch's onnx builds. For now, mitigate by pinning the script to an older version until there's a proper solution Pull Request resolved: #91929 Approved by: https://github.com/justinchuby, https://github.com/kit1980
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.