fix(atenlib): Cast SymInt to INT64 to fix Windows CI #292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #292 +/- ##
==========================================
- Coverage 73.26% 72.73% -0.54%
==========================================
Files 95 95
Lines 9171 9176 +5
==========================================
- Hits 6719 6674 -45
- Misses 2452 2502 +50
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
fatcat-z
reviewed
Jan 9, 2023
| # FIXME(#277): Script when attributes can come before inputs | ||
| @torch_op("aten::index_select", trace_only=True) | ||
| def aten_index_select(self: TTensor, dim: int, index: TInt) -> TTensor: | ||
| def aten_index_select(self: TTensor, dim: int, index: IntType) -> TTensor: |
There was a problem hiding this comment.
Why can't we keep TInt here? Looks like they are the same to me.
If we are using Txxx in most of places, I'd like to use the same style.
There was a problem hiding this comment.
Since mypy requires a TypeVar to appear at least twice in the signature of a generic function, we are forced to use a plain type here.
There was a problem hiding this comment.
Actually, we can probably get away with TInt here. Let me try again and replace as many with TInt.
justinchuby
added
module: torchlib
abock
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyTorch can supply int32 inputs as SymInt values. This change adds explicit casts to them to fix the Windows CI.
Fixed additional mypy errors
#289 may be needed for python3.10