fix(atenlib): bitwise_not and maskd_fill #442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinchuby
reviewed
Feb 15, 2023
| def aten_masked_fill(self: TTensor, mask: BOOL, value: TTensor) -> TTensor: | ||
| # masked_fill.Tensor(Tensor self, Tensor mask, Tensor value) -> Tensor | ||
| mask_cast = op.Cast(mask, to=BOOL.dtype) | ||
| value_cast = op.CastLike(value, self) |
There was a problem hiding this comment.
maybe add a note along this line?
# NOTE: Do not attempt to cast `mask` to BOOL because mask should not take any other types.
# `mask` coming in as other types is often an error and should fail the model.
justinchuby
approved these changes
Feb 15, 2023
justinchuby
changed the title
justinchuby
changed the title
justinchuby
added
the
module: torchlib
Codecov Report
@@ Coverage Diff @@
## main #442 +/- ##
==========================================
- Coverage 71.27% 71.27% -0.01%
==========================================
Files 108 108
Lines 10475 10478 +3
Branches 1085 1086 +1
==========================================
+ Hits 7466 7468 +2
- Misses 2699 2700 +1
Partials 310 310
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a bool overload for bitwise_not and fix an incorrect cast in maskd_fill
Discovered when running bloom export.