Skip to content

fix(atenlib): bitwise_not and maskd_fill #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 15, 2023
Merged

fix(atenlib): bitwise_not and maskd_fill #442

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
541dcf5
bloom needed minor changes on Ops
titaiwangms Feb 15, 2023
c1f9206
add comments
titaiwangms Feb 15, 2023
e351070
Merge branch 'main' into titaiwang/bitwisenot_and_maskfill
titaiwangms Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions onnxscript/function_libs/torch_aten/ops/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -769,6 +769,12 @@ def aten_bitwise_not(self: TInt) -> TInt:
return op.BitwiseNot(self)


@torch_op("aten::bitwise_not", overload=True)
def aten_bitwise_not_bool(self: BOOL) -> BOOL:
# bitwise_not(Tensor self) -> Tensor
return op.Not(self)


@torch_op("aten::bitwise_or")
def aten_bitwise_or(self: TInt, other: TInt) -> TInt:
# bitwise_or.Tensor(Tensor self, Tensor other) -> Tensor
Expand Down Expand Up @@ -3146,9 +3152,10 @@ def aten_margin_ranking_loss(
@torch_op("aten::masked_fill")
def aten_masked_fill(self: TTensor, mask: BOOL, value: TTensor) -> TTensor:
# masked_fill.Tensor(Tensor self, Tensor mask, Tensor value) -> Tensor
mask_cast = op.Cast(mask, to=BOOL.dtype)
# NOTE: Do not attempt to cast `mask` to BOOL because mask should not take any other types.
# `mask` coming in as other types is often an error and should fail the model.
value_cast = op.CastLike(value, self)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add a note along this line?

# NOTE: Do not attempt to cast `mask` to BOOL because mask should not take any other types.
# `mask` coming in as other types is often an error and should fail the model.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

return op.Where(mask_cast, value_cast, self)
return op.Where(mask, value_cast, self)


def aten_masked_scatter(self: TensorType, mask: TensorType, source: TensorType) -> TensorType:
Expand Down