Skip to content

Conversation

@titaiwangms
Copy link
Contributor

Remove If subgraph

@titaiwangms titaiwangms requested a review from justinchuby April 13, 2023 18:06
@titaiwangms titaiwangms added the module: torchlib Related to the torch/aten function lib in development label Apr 13, 2023
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #628 (69582e9) into main (d49dbfc) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #628      +/-   ##
==========================================
+ Coverage   74.28%   74.30%   +0.01%     
==========================================
  Files         107      107              
  Lines       11333    11333              
  Branches     1179     1178       -1     
==========================================
+ Hits         8419     8421       +2     
+ Misses       2591     2590       -1     
+ Partials      323      322       -1     
Impacted Files Coverage Δ
onnxscript/function_libs/torch_aten/ops/core.py 73.78% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@justinchuby justinchuby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@titaiwangms
Copy link
Contributor Author

@justinchuby The fails are expected?

@justinchuby
Copy link
Collaborator

Do you see any new ones other than #539 ?

@titaiwangms titaiwangms merged commit a9fc6ca into microsoft:main Apr 13, 2023
@titaiwangms titaiwangms deleted the titaiwang/improve_unflatten branch April 13, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: torchlib Related to the torch/aten function lib in development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants