Analyze type annotation for input types | feat(op_schema) #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

justinchuby merged 61 commits into main from gh/justinchuby/17/head

Apr 28, 2023

Collaborator

justinchuby commented Apr 14, 2023 •

edited

Loading

Stack from ghstack (oldest at bottom):

justinchuby added 21 commits

April 12, 2023 17:30


          Move version_utils to _internal | chore

c6505cf

Move version_utils to `_internal` so that it can be used my onnxscript

[ghstack-poisoned]


          Merge attrs and attr_protos in IRFunction | chore(irbuilder)

268ad8f

[ghstack-poisoned]


          Update base for Update on "Merge attrs and attr_protos in `IRFunc…

1f900c1

…tion` | chore(irbuilder)"


Merge the two list in `IRFunction` by adding a `has_default` field in `IRAttributeValue`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]


          Update on "Merge attrs and attr_protos in IRFunction | chore(ir…

01f9378

…builder)"


Merge the two list in `IRFunction` by adding a `has_default` field in `IRAttributeValue`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]


          Update base for Update on "Merge attrs and attr_protos in `IRFunc…

1b7391e

…tion` | chore(irbuilder)"


Merge the two list in `IRFunction` by adding a `has_default` field in `IRAttributeValue`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]


          Update on "Merge attrs and attr_protos in IRFunction | chore(ir…

304fa0d

…builder)"


Merge the two list in `IRFunction` by adding a `has_default` field in `IRAttributeValue`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]


          Update base for Update on "Merge attrs and attr_protos in `IRFunc…

ac60dce

…tion` | chore(irbuilder)"


Merge the two list in `IRFunction` by adding a `has_default` field in `IRAttributeValue`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]


          Update on "Merge attrs and attr_protos in IRFunction | chore(ir…

3eb45c6

…builder)"


Merge the two list in `IRFunction` by adding a `has_default` field in `IRAttributeValue`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]


          Update base for Update on "Merge attrs and attr_protos in `IRFunc…

f7b9b79

…tion` | chore(irbuilder)"


Merge the two list in `IRFunction` by adding a `has_default` field in `IRAttributeValue`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]


          Update on "Merge attrs and attr_protos in IRFunction | chore(ir…

59523f5

…builder)"


Merge the two list in `IRFunction` by adding a `has_default` field in `IRAttributeValue`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]


          Update base for Update on "Merge attrs and attr_protos in `IRFunc…

758ce59

…tion` | chore(irbuilder)"


Merge the two list in `IRFunction` by adding a `has_default` field in `IRAttributeValue`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]


          Update on "Merge attrs and attr_protos in IRFunction | chore(ir…

fdd2f22

…builder)"


Merge the two list in `IRFunction` by adding a `has_default` field in `IRAttributeValue`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]


          Update base for Update on "Merge attrs and attr_protos in `IRFunc…

d4b0db6

…tion` | chore(irbuilder)"


Merge the two list in `IRFunction` by changing its type to `IRAttributeParameter`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]


          Update on "Merge attrs and attr_protos in IRFunction | chore(ir…

cc977b1

…builder)"


Merge the two list in `IRFunction` by changing its type to `IRAttributeParameter`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]


          Update base for Update on "Merge attrs and attr_protos in `IRFunc…

8ffd7e7

…tion` | chore(irbuilder)"


Merge the two list in `IRFunction` by changing its type to `IRAttributeParameter`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]


          Update on "Merge attrs and attr_protos in IRFunction | chore(ir…

831a416

…builder)"


Merge the two list in `IRFunction` by changing its type to `IRAttributeParameter`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]


          Update base for Update on "Merge attrs and attr_protos in `IRFunc…

1fd4d2e

…tion` | chore(irbuilder)"


Merge the two list in `IRFunction` by changing its type to `IRAttributeParameter`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]


          Update on "Merge attrs and attr_protos in IRFunction | chore(ir…

62105f3

…builder)"


Merge the two list in `IRFunction` by changing its type to `IRAttributeParameter`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]


          Update base for Update on "Merge attrs and attr_protos in `IRFunc…

9c6bfae

…tion` | chore(irbuilder)"


Merge the two list in `IRFunction` by changing its type to `IRAttributeParameter`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]


          Update on "Merge attrs and attr_protos in IRFunction | chore(ir…

c63ccd5

…builder)"


Merge the two list in `IRFunction` by changing its type to `IRAttributeParameter`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]


          Analyze type annotation for input types | feat(op_schema)

4e38a29

[ghstack-poisoned]

This was referenced Apr 14, 2023

Merge attrs and attr_protos in IRFunction | chore(irbuilder) #625

Merged

Auto generate OpSchema for functions | feat(op_schema) #626

Merged

justinchuby marked this pull request as draft

April 14, 2023 01:43

justinchuby requested review from BowenBao, gramalingam, shubhambhokare1 and titaiwangms

April 14, 2023 01:43


          Update on "Analyze type annotation for input types | feat(op_schema)"

b34551c

[ghstack-poisoned]

justinchuby commented

View reviewed changes

onnxscript/type_annotation.py Outdated Show resolved Hide resolved


          Update on "Analyze type annotation for input types | feat(op_schema)"

9d7d12f

[ghstack-poisoned]

This was referenced Apr 27, 2023

Refactor converter to isolate translate_function_signature logic | feat(converter) #684

Merged

Implement split_function_and_wrangler | test(torchlib) #686

Closed

justinchuby added 2 commits

April 27, 2023 04:08


          Update base for Update on "Analyze type annotation for input types | …

e61bffe

…feat(op_schema)"

[ghstack-poisoned]


          Update on "Analyze type annotation for input types | feat(op_schema)"

52c198e

[ghstack-poisoned]

justinchuby mentioned this pull request

Implement split_function_and_wrangler | test(torchlib) #688

Merged

gramalingam reviewed

View reviewed changes

onnxscript/type_annotation.py Outdated Show resolved Hide resolved

justinchuby mentioned this pull request

Create the OpLike protocol and refactor Op | feat(values) #692

Closed

gramalingam reviewed

View reviewed changes

onnxscript/type_annotation.py Outdated Show resolved Hide resolved

justinchuby changed the base branch from main to gh/justinchuby/17/base

April 27, 2023 16:50

justinchuby added the change base before merge label

justinchuby added a commit that referenced this pull request


          Analyze type annotation for input types | feat(op_schema)

e155fe3

ghstack-source-id: 356be97
Pull Request resolved: #631

Signed-off-by: Justin Chu <justinchu@microsoft.com>

gramalingam approved these changes

View reviewed changes

Collaborator

gramalingam left a comment

I think your latest changes have probably not been pushed yet!

Collaborator Author

justinchuby commented Apr 27, 2023 •

edited

Loading

I think your latest changes have probably not been pushed yet!

Yes. ghstack is trying to push 6 changes and they were rejected by github because of our repo settings. Could you help relax that limit?

BowenBao approved these changes

View reviewed changes

Contributor

BowenBao left a comment

Non-blocking minor comments/questions.

onnxscript/type_annotation.py Outdated

    
              _LIST_CONSTRUCTORS = frozenset([list, typing.List, typing.Sequence, collections.abc.Sequence])

              # A sorted list of all type strings used in an OpSchema

              ALL_TENSOR_TYPE_STRINGS = (

Contributor

BowenBao Apr 27, 2023

nit: must this be hardcoded?

Collaborator Author

justinchuby Apr 27, 2023

Not sure where else we can find it?

Collaborator

gramalingam Apr 27, 2023

I guess you could compute it by iterating over tensor_type_registry ... it would be convenient to have the to_string method defined in one of the other PRs.

Collaborator

gramalingam Apr 27, 2023

But do you want the 8-bit floats included in this?

Collaborator Author

justinchuby Apr 27, 2023

Great, I can use tensor_type_registry. I think 8-floats are fine

Collaborator Author

justinchuby Apr 28, 2023

Done

onnxscript/type_annotation.py

    
                  raise ValueError(f"Unsupported type: {pytype}")

              def get_type_constraint_name(pytype: TypeAnnotationValue) -> Optional[str]:

Contributor

BowenBao Apr 27, 2023

When is this function used/useful?

Collaborator Author

justinchuby Apr 27, 2023

It’s used for converting Python function signatures into onnx type constraints. The tests show usage. You can find actual usage in #626 and #674

justinchuby added 2 commits

April 27, 2023 22:28


          Update base for Update on "Analyze type annotation for input types | …

a37fb92

…feat(op_schema)"

[ghstack-poisoned]


          Update on "Analyze type annotation for input types | feat(op_schema)"

d1a24ef

[ghstack-poisoned]

justinchuby added a commit that referenced this pull request


          Implement split_function_and_wrangler | test(torchlib) (#688)

a05ab66

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at
bottom):
* #692
* #674
* #684
* #626
* #631
* __->__ #688

justinchuby changed the base branch from gh/justinchuby/17/base to main

April 27, 2023 22:41

justinchuby and others added 7 commits

April 28, 2023 02:47


          Update base for Update on "Analyze type annotation for input types | …

dcd74de

…feat(op_schema)"

[ghstack-poisoned]


          Update on "Analyze type annotation for input types | feat(op_schema)"

[ghstack-poisoned]


          Update base for Update on "Analyze type annotation for input types | …

6160dbc

…feat(op_schema)"

[ghstack-poisoned]


          Update on "Analyze type annotation for input types | feat(op_schema)"

83cc202

[ghstack-poisoned]


          Update base for Update on "Analyze type annotation for input types | …

d69a130

…feat(op_schema)"

[ghstack-poisoned]


          Update on "Analyze type annotation for input types | feat(op_schema)"

9dc0937

[ghstack-poisoned]


          Merge branch 'main' into gh/justinchuby/17/head

22ac02a

justinchuby merged commit 0b633ea into main

justinchuby deleted the gh/justinchuby/17/head branch

April 28, 2023 03:46

Indie365 pushed a commit to Indie365/onnxscript that referenced this pull request


          Analyze type annotation for input types | feat(op_schema)

bf8f3d7

ghstack-source-id: 462ff66
Pull Request resolved: microsoft/onnxscript#631

Signed-off-by: Justin Chu <justinchu@microsoft.com>

Indie365 pushed a commit to Indie365/onnxscript that referenced this pull request


          Analyze type annotation for input types | feat(op_schema)

1e2518b

ghstack-source-id: fe340e0
Pull Request resolved: microsoft/onnxscript#631

Signed-off-by: Justin Chu <justinchu@microsoft.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gramalingam gramalingam approved these changes

titaiwangms titaiwangms left review comments

fatcat-z fatcat-z left review comments

shubhambhokare1 Awaiting requested review from shubhambhokare1

xiaowuhu Awaiting requested review from xiaowuhu

+1 more reviewer

BowenBao BowenBao approved these changes

Labels

change base before merge topic: typing