Skip to content

Conversation

Move version_utils to `_internal` so that it can be used my onnxscript

[ghstack-poisoned]
…tion` | chore(irbuilder)"


Merge the two list in `IRFunction` by adding a `has_default` field in `IRAttributeValue`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]
…builder)"


Merge the two list in `IRFunction` by adding a `has_default` field in `IRAttributeValue`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]
…tion` | chore(irbuilder)"


Merge the two list in `IRFunction` by adding a `has_default` field in `IRAttributeValue`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]
…builder)"


Merge the two list in `IRFunction` by adding a `has_default` field in `IRAttributeValue`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]
…tion` | chore(irbuilder)"


Merge the two list in `IRFunction` by adding a `has_default` field in `IRAttributeValue`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]
…builder)"


Merge the two list in `IRFunction` by adding a `has_default` field in `IRAttributeValue`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]
…tion` | chore(irbuilder)"


Merge the two list in `IRFunction` by adding a `has_default` field in `IRAttributeValue`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]
…builder)"


Merge the two list in `IRFunction` by adding a `has_default` field in `IRAttributeValue`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]
…tion` | chore(irbuilder)"


Merge the two list in `IRFunction` by adding a `has_default` field in `IRAttributeValue`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]
…builder)"


Merge the two list in `IRFunction` by adding a `has_default` field in `IRAttributeValue`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]
…tion` | chore(irbuilder)"


Merge the two list in `IRFunction` by changing its type to `IRAttributeParameter`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]
…builder)"


Merge the two list in `IRFunction` by changing its type to `IRAttributeParameter`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]
…tion` | chore(irbuilder)"


Merge the two list in `IRFunction` by changing its type to `IRAttributeParameter`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]
…builder)"


Merge the two list in `IRFunction` by changing its type to `IRAttributeParameter`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]
…tion` | chore(irbuilder)"


Merge the two list in `IRFunction` by changing its type to `IRAttributeParameter`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]
…builder)"


Merge the two list in `IRFunction` by changing its type to `IRAttributeParameter`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]
…tion` | chore(irbuilder)"


Merge the two list in `IRFunction` by changing its type to `IRAttributeParameter`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]
…builder)"


Merge the two list in `IRFunction` by changing its type to `IRAttributeParameter`. This way we retain type information for all attributes. It is useful for creating correct `OpSchema`s and `ParamSchema`s in the next PR.

Also Include `typeinfo` in `add_attr_parameter`.

[ghstack-poisoned]
justinchuby added a commit that referenced this pull request Apr 27, 2023
ghstack-source-id: 266c0f9
Pull Request resolved: #688
@justinchuby justinchuby changed the base branch from gh/justinchuby/22/base to main April 27, 2023 22:29
@justinchuby justinchuby merged commit a05ab66 into main Apr 27, 2023
@justinchuby justinchuby deleted the gh/justinchuby/22/head branch April 27, 2023 22:41
@justinchuby justinchuby restored the gh/justinchuby/22/head branch April 27, 2023 22:41
justinchuby added a commit that referenced this pull request Apr 28, 2023
@justinchuby justinchuby deleted the gh/justinchuby/22/head branch March 13, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change base before merge Remember to change the merge base to main when the PR is ready to merge module: torchlib Related to the torch/aten function lib in development topic: testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants