This repository was archived by the owner on Jul 28, 2021. It is now read-only.
service/gcsutil/gcstools: simplify s[:] to s#260
Merged
jterry75 merged 1 commit intomicrosoft:masterfrom Oct 2, 2018
quasilyte:quasilyte/unslice
Merged
service/gcsutil/gcstools: simplify s[:] to s#260jterry75 merged 1 commit intomicrosoft:masterfrom quasilyte:quasilyte/unslice
jterry75 merged 1 commit intomicrosoft:masterfrom
quasilyte:quasilyte/unslice
Conversation
For s which is slice `s[:]` is identical to just `s`. https://open.microsoft.com/2018/09/30/join-hacktoberfest-2018-celebration-microsoft
Contributor
|
Thanks for the changes you are right this was silly to be doing. |
Contributor
Author
|
@jterry75, this was fast. Thanks for review! |
Contributor
|
@quasilyte Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For s which is slice
s[:]is identical to justs.https://open.microsoft.com/2018/09/30/join-hacktoberfest-2018-celebration-microsoft