Skip to content
This repository was archived by the owner on Nov 16, 2023. It is now read-only.

Conversation

@hectorhdzg
Copy link
Member

@hectorhdzg hectorhdzg requested a review from lzchen as a code owner March 26, 2020 18:49
tox.ini Outdated

[testenv:docs]
deps =
-c dev-requirements.txt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need dev-requirements.txt in the doc env?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, at least pytest is needed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind looks like there is some duplication of packages in requirement files, will clean up a little bit

# External
opentelemetry-api
opentelemetry-sdk
psutil
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get errors if I don't include psutil but I can't seem to find where in the docs it is needed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

psutil is used in PerformanceMetrics class, docs need all external libraries used in the code to be able to build

@codecov-io
Copy link

codecov-io commented Mar 27, 2020

Codecov Report

Merging #65 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #65   +/-   ##
=======================================
  Coverage   98.67%   98.67%           
=======================================
  Files          14       14           
  Lines         753      753           
  Branches       97       97           
=======================================
  Hits          743      743           
  Misses          8        8           
  Partials        2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e557a9a...ba53124. Read the comment docs.

Copy link
Contributor

@lzchen lzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@lzchen
Copy link
Contributor

lzchen commented Mar 27, 2020

@hectorhdzg hectorhdzg merged commit 3dad6c5 into microsoft:master Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants