flowey: publish hidden files in GitHub artifacts #1342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use hidden files to tag opaque directories in artifacts, but GitHub discards them out of an abundance of caution. Since we are generally quite careful about artifact construction, there is no security concern with including hidden files, so include away.
benhillis
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use hidden files to tag opaque directories in artifacts, but GitHub discards them out of an abundance of caution. Since we are generally quite careful about artifact construction, there is no security concern with including hidden files, so include away.
Also add some tests of the artifact parsing functionality, since originally I thought that might be the issue.