firmware_uefi: Add EFI Diagnostics #1439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… test arm CI with new main
maheeraeron
changed the title
maheeraeron
commented
May 29, 2025
maheeraeron
commented
May 29, 2025
maheeraeron
commented
May 29, 2025
maheeraeron
commented
May 29, 2025
Contributor
Author
|
FYI-- This PR is a rev2. The other PR I abandoned since it branched off an older branch of main that had ARM issues-- it was easier to make a new PR off a different branch that squashed and cherry-picked the changes from the original |
mebersol
added
the
backport_2505
chris-oo
reviewed
Jun 5, 2025
chris-oo
reviewed
Jun 9, 2025
Member
chris-oo
left a comment
chris-oo
left a comment
There was a problem hiding this comment.
Changes LGTM but should we probably split the uefi firmware update to a different PR for ease of cherry pick?
chris-oo
approved these changes
Jun 10, 2025
mebersol
added
backport_2505_approved
backported_2505
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds EFI Diagnostics, which is a service used to parse UEFI diagnostics data from an in-memory buffer and send it to our tracing facilities.
The UEFI firmware will write the GPA of the advanced logger buffer to an Io port intercept called
SET_EFI_DIAGNOSTICS_GPA.The diagnostics service is responsible for reading guest memory at the specified GPA and parsing the data. This gets triggered when the UEFI firmware writes to an Io port intercept called
PROCESS_EFI_DIAGNOSTICS.The
PROCESS_EFI_DIAGNOSTICSUefiCommand gets triggered by the following conditions:PROCESS_EFI_DIAGNOSTICS)PROCESS_EFI_DIAGNOSTICS)The simplest way to test this is to run:
See comments below for example output.