Add num_pkts_coalesced counter to track when packets are coalesced#2011
Merged
yuqiong6 merged 10 commits intomicrosoft:mainfrom Sep 19, 2025
Merged
Add num_pkts_coalesced counter to track when packets are coalesced#2011yuqiong6 merged 10 commits intomicrosoft:mainfrom
yuqiong6 merged 10 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds packet coalescing tracking functionality to the network device implementation by introducing a new counter to monitor when packets are coalesced during transmission.
- Added a packet coalescing counter to the MANA device (net_mana)
- Incremented the counter when segments are coalesced in the MANA transmit path
chris-oo
reviewed
Sep 16, 2025
smalis-msft
reviewed
Sep 16, 2025
erfrimod
reviewed
Sep 17, 2025
erfrimod
reviewed
Sep 17, 2025
erfrimod
approved these changes
Sep 18, 2025
smalis-msft
approved these changes
Sep 19, 2025
andyplank-msft
pushed a commit
to andyplank-msft/openvmm
that referenced
this pull request
Nov 4, 2025
…icrosoft#2011) Code Change Summary: - Added a packet coalescing counter to the MANA device (net_mana) - Incremented the counter when segments are coalesced in the MANA transmit path Validation The test was performed in the lab environment using the following command on the host: basicnictool.exe --mac_address AA-BB-CC-DD-EE-FF --send_packet --num_mdl 32 --payload_size 65000 Each time this command is executed, the value of queue_tx_packets_coalesced increments by one. In this case, the command was run five times, resulting in queue_tx_packets_coalesced = 5 by running following command on the host: uhdiag-dev uhvm inspect uhdiag/net/{net}/queues/{queue number} Result: { ...... queue_tx_packets: 45, queue_tx_packets_coalesced: 5, queue_tx_queued: 0, ...... }
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code Change Summary:
Validation
The test was performed in the lab environment using the following command on the host:
basicnictool.exe --mac_address AA-BB-CC-DD-EE-FF --send_packet --num_mdl 32 --payload_size 65000
Each time this command is executed, the value of queue_tx_packets_coalesced increments by one. In this case, the command was run five times, resulting in queue_tx_packets_coalesced = 5 by running following command on the host:
uhdiag-dev uhvm inspect uhdiag/net/{net}/queues/{queue number}
Result:
{
......
queue_tx_packets: 45,
queue_tx_packets_coalesced: 5,
queue_tx_queued: 0,
......
}