vmm_tests: moved keepalive test with uefi#2013
Merged
gurasinghMS merged 12 commits intomicrosoft:mainfrom Sep 18, 2025
Merged
Conversation
mattkur
reviewed
Sep 16, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
Removes a flaky NVMe keepalive test with UEFI from the OpenHCL UEFI test suite, as redundant test coverage already exists in the OpenHCL servicing tests.
- Removed the
nvme_keepalivetest function and its helpernvme_relay_servicing_core - Added the UEFI test configuration to the existing
keepalivetest inopenhcl_servicing.rs
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| vmm_tests/vmm_tests/tests/tests/x86_64/openhcl_uefi.rs | Removed flaky nvme_keepalive test and its helper function, plus unused import |
| vmm_tests/vmm_tests/tests/tests/multiarch/openhcl_servicing.rs | Added UEFI test configuration to existing keepalive test to maintain coverage |
gurasinghMS
changed the title
smalis-msft
reviewed
Sep 18, 2025
…ation function to parametrize the vmbus_redirect flag
smalis-msft
reviewed
Sep 18, 2025
smalis-msft
previously approved these changes
Sep 18, 2025
smalis-msft
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed offline this test can be removed as a similar test that exercises the keepalive codebase already exists in the
openhcl_servicing.rsfile. This test is being flaky for no good reason so it should be ok to remove.