Skip to content

Conversation

@chris-oo
Copy link
Member

An upcoming kernel change will compile in some limited acpi routines for TDX AP startup. Disable ACPI runtime functions as they are unwanted.

@chris-oo chris-oo requested a review from a team as a code owner November 19, 2025 00:09
Copilot AI review requested due to automatic review settings November 19, 2025 00:09
@github-actions github-actions bot added the unsafe Related to unsafe code label Nov 19, 2025
@github-actions
Copy link

⚠️ Unsafe Code Detected

This PR modifies files containing unsafe Rust code. Extra scrutiny is required during review.

For more on why we check whole files, instead of just diffs, check out the Rustonomicon

Copilot finished reviewing on behalf of chris-oo November 19, 2025 00:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR disables ACPI runtime support in OpenHCL by adding the acpi=off kernel command line parameter. The change is motivated by an upcoming kernel change that will compile in limited ACPI routines for TDX AP (Application Processor) startup, which are unwanted in the OpenHCL environment.

  • Adds acpi=off kernel parameter to disable ACPI runtime functions in the kernel

@chris-oo chris-oo enabled auto-merge (squash) November 19, 2025 00:54
@chris-oo chris-oo merged commit b378ddc into microsoft:main Nov 19, 2025
85 checks passed
@chris-oo chris-oo deleted the boot-acpi-off branch November 19, 2025 01:03
chris-oo added a commit to chris-oo/openvmm that referenced this pull request Nov 19, 2025
An upcoming kernel change will compile in some limited acpi routines for
TDX AP startup. Disable ACPI runtime functions as they are unwanted.
@ricardon
Copy link
Contributor

I tested this patch with the latest patches for LKML. I am able to boot successfully.

chris-oo added a commit that referenced this pull request Nov 19, 2025
An upcoming kernel change will compile in some limited acpi routines for
TDX AP startup. Disable ACPI runtime functions as they are unwanted.

Clean cherry pick of #2441
@benhillis
Copy link
Member

Backported to release/1.7.2511 in #2447

@benhillis benhillis added backported_1.7.2511 PR that has been backported to release/1.7.2511 and removed backport_1.7.2511 labels Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backported_1.7.2511 PR that has been backported to release/1.7.2511 unsafe Related to unsafe code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants