logview_new: fixed copying table data #2500
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mattkur had pointed out that when copying several line of table data from the log viewer it didn't place nicely with teams.

Investigated the root cause for this and found that the virtualized table was rendering each row as a separate table. Turns out when we copy, the browser will also copy the HTML formatting as part of the rich text which gets pasted in teams. Because teams will then treat these as separate tables, the paste will appear funky.
Moved the "table" tag out of the virtualizer so that each row is just a "tr" now. Pasting in teams seems to work now test paste looks like:
Also increased overscan for the log viewer to 300 rows. While you still can't copy all the data in one go, copying up to 300 rows at once should be sufficient