vmm_tests: servicing tests can run on nested amd#2742
Merged
benhillis merged 3 commits intomicrosoft:mainfrom Apr 15, 2026
Merged
vmm_tests: servicing tests can run on nested amd#2742benhillis merged 3 commits intomicrosoft:mainfrom
benhillis merged 3 commits intomicrosoft:mainfrom
Conversation
Contributor
Author
|
Note: we may need to update our CI runners to get the fix. Let's see what happens in CI... But, this works on a default Azure Dev Box VM running on AMD processors. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a test requirement restriction that prevented OpenHCL servicing tests from running on AMD processors in nested virtualization environments. The blocking bugs that necessitated this restriction have been resolved and deployed.
Changes:
- Removed the special case code in
build_requirements()that excluded AMD + Nested execution environments for tests with "servicing" in their name
Contributor
Author
|
Yep, we need to update the CI runners first. |
jennagoddard
previously approved these changes
Feb 6, 2026
mattkur
added
the
release-ci-required
benhillis
approved these changes
Apr 15, 2026
gurasinghMS
pushed a commit
to gurasinghMS/openvmm
that referenced
this pull request
Apr 17, 2026
The bugs that blocked our servicing tests on AMD in a VM are now resolved and deployed. Remove the block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bugs that blocked our servicing tests on AMD in a VM are now resolved and deployed. Remove the block.