netvsp: adding test for subchannel request max#2799
Merged
erfrimod merged 2 commits intomicrosoft:mainfrom Feb 26, 2026
Merged
Conversation
erfrimod
force-pushed
the
erfrimod/subchannel-index-oob
branch
from
5af0803 to
fc779cd
Compare
erfrimod
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a unit test to validate the fix in PR #2430, which prevents crashes when the number of requested subchannels equals or exceeds the maximum queue limit. The PR also adds a defensive check during restore to log if saved state contains more channels than the adapter supports.
Changes:
- Adds unit test
subchannel_request_equal_to_max_queues_rejectedto verify subchannel requests at the boundary are properly rejected - Adds defensive logging in restore path if saved state has more channels than adapter supports
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| vm/devices/net/netvsp/src/test.rs | New test verifying that requesting num_sub_channels == max_queues is rejected with FAILURE status |
| vm/devices/net/netvsp/src/lib.rs | Defensive check logging an error if restored channels exceed max_queues |
sunilmut
reviewed
Feb 20, 2026
sunilmut
requested changes
Feb 20, 2026
Brian-Perkins
approved these changes
Feb 25, 2026
sunilmut
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are crash dumps from netvsp restore_queues()
driver: Box::new(drivers[queue_index as usize].clone()),Should be fixed by #2430