Merged
Conversation
|
This PR modifies files containing For more on why we check whole files, instead of just diffs, check out the Rustonomicon |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the unused “vMCR” device plumbing from the workspace now that the shipped implementation has superseded it.
Changes:
- Deletes the
mcr_resourcescrate and removes it from the workspace dependency list/lockfile. - Removes the OpenVMM CLI flag (
--mcr) and the associated device instantiation code path. - Removes the Underhill/OpenHCL environment option and instantiation logic for the MCR device.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| vm/devices/mcr_resources/src/lib.rs | Removes the MCR resource handle type (crate deleted). |
| vm/devices/mcr_resources/Cargo.toml | Removes the mcr_resources crate manifest (crate deleted). |
| openvmm/openvmm_entry/src/lib.rs | Drops the opt.mcr-gated VPCI device injection. |
| openvmm/openvmm_entry/src/cli_args.rs | Removes the --mcr CLI flag definition. |
| openvmm/openvmm_entry/Cargo.toml | Removes the mcr_resources dependency. |
| openhcl/underhill_core/src/worker.rs | Removes MCR controller injection into controllers.vpci_devices; cleans up now-unneeded mutability. |
| openhcl/underhill_core/src/options.rs | Removes OPENHCL_MCR_DEVICE parsing and the mcr option field. |
| openhcl/underhill_core/src/lib.rs | Removes propagation of the mcr option into UnderhillEnvCfg. |
| openhcl/underhill_core/Cargo.toml | Removes the mcr_resources dependency. |
| Cargo.toml | Removes mcr_resources from workspace dependencies. |
| Cargo.lock | Removes the mcr_resources package entry and references from dependents. |
jstarks
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the proper version of the feature has shipped this is no longer needed or being used.