Skip to content

Repo: Delete vMCR#3199

Merged
smalis-msft merged 2 commits intomicrosoft:mainfrom
smalis-msft:vmcr
Apr 7, 2026
Merged

Repo: Delete vMCR#3199
smalis-msft merged 2 commits intomicrosoft:mainfrom
smalis-msft:vmcr

Conversation

@smalis-msft
Copy link
Copy Markdown
Contributor

Now that the proper version of the feature has shipped this is no longer needed or being used.

Copilot AI review requested due to automatic review settings April 6, 2026 15:59
@smalis-msft smalis-msft requested a review from a team as a code owner April 6, 2026 15:59
@github-actions github-actions bot added the unsafe Related to unsafe code label Apr 6, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 6, 2026

⚠️ Unsafe Code Detected

This PR modifies files containing unsafe Rust code. Extra scrutiny is required during review.

For more on why we check whole files, instead of just diffs, check out the Rustonomicon

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the unused “vMCR” device plumbing from the workspace now that the shipped implementation has superseded it.

Changes:

  • Deletes the mcr_resources crate and removes it from the workspace dependency list/lockfile.
  • Removes the OpenVMM CLI flag (--mcr) and the associated device instantiation code path.
  • Removes the Underhill/OpenHCL environment option and instantiation logic for the MCR device.

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
vm/devices/mcr_resources/src/lib.rs Removes the MCR resource handle type (crate deleted).
vm/devices/mcr_resources/Cargo.toml Removes the mcr_resources crate manifest (crate deleted).
openvmm/openvmm_entry/src/lib.rs Drops the opt.mcr-gated VPCI device injection.
openvmm/openvmm_entry/src/cli_args.rs Removes the --mcr CLI flag definition.
openvmm/openvmm_entry/Cargo.toml Removes the mcr_resources dependency.
openhcl/underhill_core/src/worker.rs Removes MCR controller injection into controllers.vpci_devices; cleans up now-unneeded mutability.
openhcl/underhill_core/src/options.rs Removes OPENHCL_MCR_DEVICE parsing and the mcr option field.
openhcl/underhill_core/src/lib.rs Removes propagation of the mcr option into UnderhillEnvCfg.
openhcl/underhill_core/Cargo.toml Removes the mcr_resources dependency.
Cargo.toml Removes mcr_resources from workspace dependencies.
Cargo.lock Removes the mcr_resources package entry and references from dependents.

@smalis-msft smalis-msft merged commit fba1dfd into microsoft:main Apr 7, 2026
61 checks passed
@smalis-msft smalis-msft deleted the vmcr branch April 7, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

unsafe Related to unsafe code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants