Merged
Conversation
benhillis
approved these changes
Apr 6, 2026
jstarks
approved these changes
Apr 6, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a CI configuration collision where the mi-secure OpenHCL gates were still targeting the pre-#3143 runner pools/images, by switching them to the updated 1ES pool/image identifiers across Flowey pipeline generation and the generated CI YAMLs.
Changes:
- Update mi-secure build/test gates in
checkin_gates.rsto usegh_pools::{linux_1es, windows_intel_1es}. - Regenerate ADO pipeline YAML to use the new pool name +
1ES.ImageOverridedemand format for the mi-secure jobs. - Regenerate GitHub Actions workflows to use the new
1ES.Pool=.../1ES.ImageOverride=...labels for the mi-secure jobs.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| flowey/flowey_hvlite/src/pipelines/checkin_gates.rs | Switch mi-secure gates to the new GitHub 1ES runner pools. |
| ci-flowey/openvmm-pr.yaml | Update ADO pool config for mi-secure jobs to new pool + image demand format. |
| .github/workflows/openvmm-pr.yaml | Update mi-secure jobs’ runs-on labels to new 1ES pool/image identifiers. |
| .github/workflows/openvmm-pr-release.yaml | Same 1ES pool/image label updates for PR-release workflow. |
| .github/workflows/openvmm-ci.yaml | Same 1ES pool/image label updates for CI workflow. |
This was referenced Apr 6, 2026
1 task
moor-coding
pushed a commit
to moor-coding/openvmm
that referenced
this pull request
Apr 13, 2026
microsoft#3143 renamed our CI pools at the same time as microsoft#3161 added a new test on the old pools. Fix this up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3143 renamed our CI pools at the same time as #3161 added a new test on the old pools. Fix this up.