nvme_driver: disable nvme keepalive#3267
Merged
mattkur merged 2 commits intomicrosoft:mainfrom Apr 15, 2026
Merged
Conversation
alandau
previously approved these changes
Apr 13, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates OpenHCL boot command-line parsing so NVMe keepalive is disabled unless explicitly re-enabled, and adjusts servicing tests to force keepalive on during those scenarios.
Changes:
- Change
OPENHCL_DISABLE_NVME_KEEP_ALIVEparsing to disable keepalive when the flag is present, with=0acting as an explicit opt-out. - Update multiarch servicing keepalive tests/config helpers to pass
OPENHCL_DISABLE_NVME_KEEP_ALIVE=0to preserve keepalive behavior under the new default.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| vmm_tests/vmm_tests/tests/tests/multiarch/openhcl_servicing.rs | Updates OpenHCL command line used by keepalive tests to explicitly re-enable keepalive (=0). |
| openhcl/openhcl_boot/src/cmdline.rs | Adjusts command-line parsing so keepalive disabling becomes the default behavior when the option is present. |
alandau
previously approved these changes
Apr 13, 2026
chris-oo
previously approved these changes
Apr 14, 2026
really disable by default fix unit tests vmm test fixups
mattkur
added
release-ci-required
alandau
approved these changes
Apr 15, 2026
mattkur
added a commit
to mattkur/openvmm
that referenced
this pull request
Apr 15, 2026
While we have a workaround for host-side device behavior, this may exacerbate another issue we are seeing in production. So: disable to guarantee safety until this can be sorted out. ( :( ) (cherry picked from commit e84570e)
gurasinghMS
pushed a commit
to gurasinghMS/openvmm
that referenced
this pull request
Apr 17, 2026
While we have a workaround for host-side device behavior, this may exacerbate another issue we are seeing in production. So: disable to guarantee safety until this can be sorted out. ( :( )
gurasinghMS
added a commit
to gurasinghMS/openvmm
that referenced
this pull request
Apr 24, 2026
This reverts commit e84570e.
gurasinghMS
added a commit
to gurasinghMS/openvmm
that referenced
this pull request
May 7, 2026
This reverts commit e84570e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While we have a workaround for host-side device behavior, this may exacerbate another issue we are seeing in production.
So: disable to guarantee safety until this can be sorted out. ( :( )