uh_core: Don't enable vendoring for crypto#3426
Merged
smalis-msft merged 2 commits intomicrosoft:mainfrom May 6, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies OpenHCL’s crypto configuration by removing the vendored feature from underhill_core’s dependency on the workspace crypto crate, relying instead on system / prebuilt OpenSSL libraries as intended by the build environment.
Changes:
- Drop
vendoredfromcryptofeatures inopenhcl/underhill_core. - Apply TOML formatting changes for multi-item feature arrays and dependency feature lists.
chris-oo
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenHCL doesn't need vendoring specified for its crypto, as we already override all of the settings to use our prebuilt openvmm-deps binaries when doing real builds. For local dev we already tell people to install libssl-dev, so this removal shouldn't break anything. Will make it cleaner to switch to symcrypt in the future.