CI: Switch from powershell to pwsh#3456
Open
smalis-msft wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Switch PowerShell invocations from Windows PowerShell (powershell.exe) to PowerShell 7 (pwsh.exe) to reduce flakiness from PowerShell startup crashes.
Changes:
- Update the internal PowerShell command builder to spawn
pwsh.exe. - Update Hyper-V tooling to run scripts using
pwsh.exe.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| support/powershell_builder/src/lib.rs | Uses pwsh.exe when constructing PowerShell commands. |
| hyperv/tools/hypestv/src/windows/hyperv.rs | Uses pwsh.exe when running PowerShell scripts for Hyper-V. |
| /// Create a new PowerShell command | ||
| pub fn new() -> Self { | ||
| PowerShellCmdletBuilder(Command::new("powershell.exe")) | ||
| PowerShellCmdletBuilder(Command::new("pwsh.exe")) |
|
|
||
| pub fn powershell_script(script: &str, args: &[&str]) -> anyhow::Result<String> { | ||
| let mut cmd = std::process::Command::new("powershell.exe"); | ||
| let mut cmd = std::process::Command::new("pwsh.exe"); |
smalis-msft
added
the
release-ci-required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've been seeing a lot of test flakiness lately that seems to be coming from powershell itself crashing during startup, not any of our code. Claude seems to think that switching to the newer pwsh should fix it. Let's see what happens.
Alternative to #3457