inspect: Fix an extreme overflow case in natural_sort#3487
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a panic in natural_sort::parse_prefix where n * base + digit could overflow u64 even when n * base did not, by combining the multiply and add via checked_add.
Changes:
- Replace
n.checked_mul(...)followed by unchecked+ dwith chainedchecked_mul().and_then(checked_add). - Add a regression test exercising a decimal value that triggers the previously-panicking overflow path.
chris-oo
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by fuzzers.