feat: Improve thread_aware APIs and anyspawn rt compat. by ralfbiedert · Pull Request #403 · microsoft/oxidizer

ralfbiedert · 2026-05-05T13:01:28Z

No description provided.

Copilot

Pull request overview

This PR upgrades the workspace to thread_aware v0.7.0 (breaking), updating downstream crates (tick, uniflight, bytesbuf, http_extensions, seatbelt, etc.) to the new in-place ThreadAware::relocate(&mut self, Option<Affinity>, Affinity) API and the unified Affinity type. It also refactors anyspawn to a new custom-spawner model (SpawnCustom) and expands thread_aware to better support dyn ThreadAware via Arc<T, S>.

Changes:

thread_aware: replace relocated(self, MemoryAffinity, PinnedAffinity) -> Self with in-place relocate(&mut self, Option<Affinity>, Affinity), remove MemoryAffinity/PinnedAffinity, and add Arc<T, S> support for T: ?Sized plus clone-fn support for trait objects.
Update tick, uniflight, bytesbuf, http_extensions, seatbelt, etc. to compile against thread_aware v0.7.0 and refresh docs/snapshots accordingly.
anyspawn: redesign custom spawning around SpawnCustom + layered builder; introduce spawn_anywhere based on thread-aware async closures.

Reviewed changes

Copilot reviewed 98 out of 99 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
crates/uniflight/src/lib.rs	Update `ThreadAware` impl/tests to new `relocate` + `Affinity` API.
crates/uniflight/README.md	Refresh generated docs/links for new `thread_aware` version.
crates/tick/src/state.rs	Migrate `ThreadAware` impls from `relocated` to in-place `relocate`.
crates/tick/src/snapshots/tick__clock__tests__debug_alive_system_clock_relocated.snap	Snapshot update for `PinnedAffinity` → `Affinity` debug output.
crates/tick/src/runtime/mod.rs	Update docs/examples to use `ThreadAware::relocate`.
crates/tick/src/runtime/inactive_clock.rs	Migrate `InactiveClock` relocation to in-place API.
crates/tick/src/lib.rs	Update thread-aware helper macro to new `relocate` signature.
crates/tick/src/error.rs	Update relocation test to in-place `relocate`.
crates/tick/src/clock.rs	Convert clock relocation and related tests to new API.
crates/tick/README.md	Refresh generated docs/links for `thread_aware` v0.7.0.
crates/thread_aware/tests/transfer_pass.rs	Update derive test to new `relocate` API and trait import.
crates/thread_aware/tests/dyn_trait.rs	Add coverage for `Arc<dyn ThreadAware, _>` constructors.
crates/thread_aware/tests/derive_compiles.rs	Update derive compilation test to in-place relocation.
crates/thread_aware/src/wrappers.rs	Update `Unaware` to new `relocate` API and add `Send` bound.
crates/thread_aware/src/registry.rs	Replace stored affinities with `Affinity` and return `Option<Affinity>`.
crates/thread_aware/src/lib.rs	Update docs/re-exports; adjust derive docs to `relocate`.
crates/thread_aware/src/impls.rs	Convert standard impls to in-place relocation; add `Box<T>` impl.
crates/thread_aware/src/core.rs	Redefine `ThreadAware` as `Send` + in-place `relocate`.
crates/thread_aware/src/closure/mod.rs	Rename closure traits/types; add async thread-aware closure support.
crates/thread_aware/src/closure/erased.rs	Update erased closure wrapper to new closure traits + `relocate`.
crates/thread_aware/src/cell/tests.rs	Update cell tests to new API and new `PerCore::new` usage.
crates/thread_aware/src/cell/storage.rs	Update storage strategy API to use `Affinity`.
crates/thread_aware/src/cell/mod.rs	Make `Arc<T, S>` support `?Sized`; add boxed ctor + clone-fn factory path.
crates/thread_aware/src/cell/factory.rs	Add erased clone-fn factory to support `dyn ThreadAware` cloning/relocation.
crates/thread_aware/src/cell/builtin.rs	Update strategy implementations to accept `Affinity`.
crates/thread_aware/src/affinity.rs	Remove `MemoryAffinity`/`PinnedAffinity`; introduce unified `Affinity`.
crates/thread_aware/README.md	Refresh generated README for v0.7.0 and new API terminology.
crates/thread_aware/CHANGELOG.md	Document breaking changes for upcoming release.
crates/thread_aware/Cargo.toml	Bump crate version to 0.7.0; add `futures` dev-dependency for tests.
crates/thread_aware_macros/Cargo.toml	Bump macros crate to 0.7.0.
crates/thread_aware_macros_impl/tests/snapshots/derive__tuple_struct_and_enum.snap	Snapshot updates for new derive output (`relocate`).
crates/thread_aware_macros_impl/tests/snapshots/derive__struct_unit.snap	Snapshot updates for new derive output (`relocate`).
crates/thread_aware_macros_impl/tests/snapshots/derive__struct_basic.snap	Snapshot updates for new derive output (`relocate`).
crates/thread_aware_macros_impl/tests/snapshots/derive__struct_attr_skip.snap	Snapshot updates for new derive output (`relocate`).
crates/thread_aware_macros_impl/tests/snapshots/derive__phantom_data_unnamed_fields.snap	Snapshot updates for new derive output (`relocate`).
crates/thread_aware_macros_impl/tests/snapshots/derive__phantom_data_named_fields.snap	Snapshot updates for new derive output (`relocate`).
crates/thread_aware_macros_impl/tests/snapshots/derive__generics_tuple_usage_adds_bound.snap	Snapshot updates for new derive output (`relocate`).
crates/thread_aware_macros_impl/tests/snapshots/derive__generics_ref_usage_adds_bound.snap	Snapshot updates for new derive output (`relocate`).
crates/thread_aware_macros_impl/tests/snapshots/derive__generics_prebound_no_dup.snap	Snapshot updates for new derive output (`relocate`).
crates/thread_aware_macros_impl/tests/snapshots/derive__generics_prebound_fq_no_dup.snap	Snapshot updates for new derive output (`relocate`).
crates/thread_aware_macros_impl/tests/snapshots/derive__generics_paren_adds_bound.snap	Snapshot updates for new derive output (`relocate`).
crates/thread_aware_macros_impl/tests/snapshots/derive__generics_group_usage_adds_bound.snap	Snapshot updates for new derive output (`relocate`).
crates/thread_aware_macros_impl/tests/snapshots/derive__generics_array_usage_adds_bound.snap	Snapshot updates for new derive output (`relocate`).
crates/thread_aware_macros_impl/tests/snapshots/derive__generics_add_bounds.snap	Snapshot updates for new derive output (`relocate`).
crates/thread_aware_macros_impl/tests/snapshots/derive__enum_unnamed_phantom_data.snap	Snapshot updates for new derive output (`relocate`).
crates/thread_aware_macros_impl/tests/snapshots/derive__enum_named_phantom_data.snap	Snapshot updates for new derive output (`relocate`).
crates/thread_aware_macros_impl/src/struct_gen.rs	Update struct derive generation to in-place field relocation.
crates/thread_aware_macros_impl/src/lib.rs	Update derive entrypoint for new trait signature/types; remove old helper.
crates/thread_aware_macros_impl/src/enum_gen.rs	Update enum derive generation to in-place field relocation.
crates/thread_aware_macros_impl/Cargo.toml	Bump macros-impl crate to 0.7.0.
crates/templated_uri/src/uri.rs	Doc import ordering/formatting tweaks.
crates/templated_uri/src/path_and_query_template.rs	Doc import ordering/formatting tweaks.
crates/templated_uri/src/lib.rs	Re-export order and doc import ordering tweaks.
crates/templated_uri/src/base_uri.rs	Doc formatting for readability.
crates/templated_uri/src/_documentation/recipes.rs	Doc formatting/import ordering tweaks.
crates/templated_uri/README.md	Refresh generated README payload + doc import ordering tweaks.
crates/templated_uri/examples/classified_templating.rs	Import ordering/formatting tweaks.
crates/seatbelt/src/retry/mod.rs	Move deprecated re-export to end of module.
crates/seatbelt/src/hedging/telemetry.rs	Import ordering tweaks + minor formatting changes.
crates/seatbelt/src/hedging/service.rs	Minor formatting change.
crates/seatbelt/src/hedging/mod.rs	Move deprecated re-export to end of module.
crates/seatbelt/src/hedging/layer.rs	Import grouping tweak.
crates/seatbelt/src/hedging/args.rs	Import ordering tweak.
crates/seatbelt/src/fallback/mod.rs	Doc formatting change.
crates/seatbelt/src/fallback/layer.rs	Import ordering tweak.
crates/seatbelt/src/context.rs	Update `ThreadAware` impl to new `relocate` + `Affinity` API.
crates/seatbelt/src/chaos/latency/mod.rs	Doc formatting tweak.
crates/seatbelt/examples/retry_advanced.rs	Import grouping tweak.
crates/recoverable/src/io.rs	Test import ordering tweak.
crates/ohno/src/lib.rs	Re-export ordering tweak.
crates/ohno/src/error_label.rs	Test import ordering tweak.
crates/http_extensions/src/http_response_builder.rs	Doc formatting tweak.
crates/http_extensions/src/http_request_builder.rs	Doc formatting tweak.
crates/http_extensions/src/fake_handler.rs	Update `ThreadAware` impl to new `relocate` + `Affinity` API + doc formatting.
crates/http_extensions/src/extensions/request_ext.rs	Import ordering tweak.
crates/http_extensions/src/error.rs	Update `ThreadAware` impl to new `relocate` + `Affinity` API + doc formatting.
crates/http_extensions/src/body/options.rs	Doc formatting tweak.
crates/http_extensions/src/body/builder.rs	Import ordering tweak + minor test formatting.
crates/http_extensions/src/_documentation/recipes.rs	Doc formatting/import ordering tweaks.
crates/cachet/src/transform/tier.rs	Import ordering tweak.
crates/cachet/src/transform/codec.rs	Doc import ordering tweak.
crates/cachet_tier/src/dynamic.rs	Import grouping tweak.
crates/cachet_memory/src/tier.rs	Import ordering tweak.
crates/cachet_memory/src/builder.rs	Doc import ordering tweak.
crates/bytesbuf/src/mem/global.rs	Update `ThreadAware` impl/tests to new in-place relocation API.
crates/anyspawn/tests/spawner.rs	Update tests to new custom spawner API; keep `cfg(not(miri))`.
crates/anyspawn/tests/relocation.rs	Rewrite relocation tests for new `SpawnCustom` model.
crates/anyspawn/tests/builder.rs	Replace snapshot-based tests with behavioral tokio tests.
crates/anyspawn/src/spawner.rs	Redesign spawner API to use `SpawnCustom`; add `spawn_anywhere`; drop `new_thread_aware`.
crates/anyspawn/src/lib.rs	Update crate docs/exports for new spawning model.
crates/anyspawn/src/custom.rs	Introduce `SpawnCustom` trait and internal bridging types for `spawn_anywhere`.
crates/anyspawn/src/builder.rs	Redesign builder layering around future transformation and `SpawnCustom`.
crates/anyspawn/README.md	Refresh generated README payload + dependency info.
crates/anyspawn/examples/thread_aware.rs	Update example from `new_thread_aware` to per-core state via `SpawnCustom`.
crates/anyspawn/examples/otel_context.rs	Update example to new builder `layer` signature.
crates/anyspawn/examples/custom.rs	Update example from closure-based custom spawning to `SpawnCustom`.
crates/anyspawn/Cargo.toml	Bump version to 0.4.0; adjust dev-deps and test ordering.
Cargo.toml	Bump workspace versions for `thread_aware*` and `anyspawn`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

codecov · 2026-05-05T14:37:33Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (1772613) to head (117bbb7).

Additional details and impacted files

@@           Coverage Diff            @@
##             main     #403    +/-   ##
========================================
  Coverage   100.0%   100.0%            
========================================
  Files         226      227     +1     
  Lines       16334    16740   +406     
========================================
+ Hits        16334    16740   +406

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot

Pull request overview

Copilot reviewed 99 out of 100 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 101 out of 102 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 101 out of 102 changed files in this pull request and generated 1 comment.

Allow for dynamic creation.

…an Option<Affinity> where needed. Make anyspawn use new ThreadAware design to allow for better spawn_anywhere.

- Replace em-dashes with hyphens in doc comments (spellcheck) - Sort anyspawn Cargo.toml dependencies (cargo-sort) - Fix stale is_unknown()/memory_affinities references in registry tests - Allow dead_code/unused lints in transfer_pass.rs compile test - Update anyspawn external types allowlist for Affinity rename Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

- Combine duplicate D: ThreadAware + D: 'static bounds (type_repetition_in_bounds) - Fix bench to use SpawnCustom impl instead of closure - Use Arc::clone() instead of .clone() on ref-counted pointers - Add reason to allow attributes (allow_attributes_without_reason) - Allow items_after_statements in test code - Fix stale 'relocated' references in doc comments - Wrap ThreadAware in backticks in doc comments (spellcheck) - Use Self in destructuring pattern (use_self) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Add tests using Tracker/Seed types with observable relocate behavior to catch cargo-mutants replacing relocate bodies with no-ops. Coverage: - impls.rs: Option, Result, Vec, Box, HashMap - closure/mod.rs: all 6 closure types (sync + async) - closure/erased.rs: ErasedClosureOnce + Wrapper - cell/tests.rs: BoxedRelocate via new_with factory - anyspawn/builder.rs: spawn_anywhere + relocate with layers - anyspawn/relocation.rs: SpawnAnywhereTask data relocation - bytesbuf, uniflight, seatbelt: skip trivial delegations Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

- Fix redundant_clone warnings with #[expect] in cell tests - Fix usize-to-i32 cast with try_from in cell tests - Add unit tests for Layered::relocate and LayeredTask::relocate in builder.rs to catch remaining 2 missed mutants Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

- Backtick-wrap spawn_anywhere in doc comment (clippy doc_markdown) - Rephrase 'dereferencing' to avoid spellcheck failure - Convert doc comments to regular comments on test function to avoid spellcheck scanning test prose Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Use non-Copy types (String) for async closure coverage tests and ensure originals are used after cloning to avoid redundant_clone lint. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Vaiz · 2026-05-07T10:48:20Z

let's merge this one first #407
it should reduce the size of this PR

ralfbiedert · 2026-05-07T12:26:06Z

let's merge this one first #407

I prefer to merge this one here first, because switching to nightly fmt is an automatic thing. Doing it the other way around means probably having to manually fix multiple rounds of merge conflicts.

Vaiz · 2026-05-07T12:44:57Z

let's merge this one first #407

I prefer to merge this one here first, because switching to nightly fmt is an automatic thing. Doing it the other way around means probably having to manually fix multiple rounds of merge conflicts.

merging PR that have changes in random crates just because of formatting is a bigger issue, I would rather avoid that

Copilot AI review requested due to automatic review settings May 5, 2026 13:01

ralfbiedert changed the title ~~feat: Improve thread_aware APIs and improve anyspawn rt compat.~~ feat: Improve thread_aware APIs and anyspawn rt compat. May 5, 2026

Copilot started reviewing on behalf of ralfbiedert May 5, 2026 13:02 View session

Copilot AI reviewed May 5, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings May 5, 2026 14:33

Copilot started reviewing on behalf of ralfbiedert-microsoft May 5, 2026 14:34 View session

Copilot AI reviewed May 5, 2026

View reviewed changes

Comment thread crates/thread_aware/src/cell/factory.rs Outdated

Comment thread crates/anyspawn/src/spawner.rs Outdated

Comment thread crates/anyspawn/tests/relocation.rs

geeknoid approved these changes May 5, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings May 5, 2026 16:21

Copilot started reviewing on behalf of ralfbiedert-microsoft May 5, 2026 16:23 View session

Copilot AI reviewed May 5, 2026

View reviewed changes

Comment thread crates/thread_aware/src/cell/clone_fn.rs Outdated

martin-kolinek reviewed May 5, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings May 6, 2026 12:23

Copilot started reviewing on behalf of ralfbiedert-microsoft May 6, 2026 12:24 View session

Copilot AI reviewed May 6, 2026

View reviewed changes

Comment thread crates/thread_aware/src/cell/mod.rs

ralfbiedert-microsoft force-pushed the u/ralfbiedert/thread_aware_anyspawn branch from ba6c6f2 to fce4dfe Compare May 6, 2026 16:21

Copilot AI review requested due to automatic review settings May 6, 2026 16:29

Copilot started reviewing on behalf of ralfbiedert-microsoft May 6, 2026 16:30 View session

ralfbiedert and others added 11 commits May 7, 2026 11:15

Make thread_aware take &mut self instead to be object safe.

c8829a6

Relax various bounds.

d4239eb

Allow for dynamic creation.

Fix clippy and fmt.

d07c9d7

Refactor closure module and add async flavors.

2d15676

Make use of Arc<dyn> in spawner.

6d81491

Fix clippy and fmt.

976f48a

Rename affinity enums: remove MemoryAffinity and make PinnedAffinity …

963300a

…an Option<Affinity> where needed. Make anyspawn use new ThreadAware design to allow for better spawn_anywhere.

Add ThreadAware for Box<T>.

bd4c3e0

Fix clippy and fmt.

976a15d

Fix comments and CI failures.

a59babe

ralfbiedert and others added 10 commits May 7, 2026 11:15

Move ErasedCloneFn into its own module for better safety containment.

73f7ef9

Add more tests for new API.

f191838

Remove dodgy unsafe that wasn't needed in the first place.

82a9843

Simplify more relocation tests.

00fac0a

Bump coverage.

148db6b

fix: resolve clippy redundant_clone in coverage tests

117bbb7

Use non-Copy types (String) for async closure coverage tests and ensure originals are used after cloning to avoid redundant_clone lint. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

ralfbiedert-microsoft force-pushed the u/ralfbiedert/thread_aware_anyspawn branch from 489e8ca to 117bbb7 Compare May 7, 2026 09:16

martin-kolinek approved these changes May 7, 2026

View reviewed changes

ralfbiedert merged commit 3b9dd96 into main May 7, 2026
28 checks passed

ralfbiedert deleted the u/ralfbiedert/thread_aware_anyspawn branch May 7, 2026 12:31

Conversation

ralfbiedert commented May 5, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented May 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Vaiz commented May 7, 2026

Uh oh!

ralfbiedert commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Vaiz commented May 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov Bot commented May 5, 2026 •

edited

Loading

ralfbiedert commented May 7, 2026 •

edited

Loading