-
Notifications
You must be signed in to change notification settings - Fork 549
add cluster version info #2528
add cluster version info #2528
Conversation
| fi | ||
|
|
||
| if kubectl get configmap | grep -q "k8s-version"; then | ||
| kubectl delete configmap k8s-version || exit $? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kubernetes-configuration.yaml has this information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is slight difference: the k8s version is our 'customized k8s' version.
For example: v0.11.0-1.9.9 may different from v0.12.0-1.9.9, although they both base on the k8s 1.9.9.
What's your suggestion about the version string schema?
| @@ -0,0 +1 @@ | |||
| v0.11.0-1.9.9 No newline at end of file | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove K8S version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My consideration is to make it different from PAI version, they would be decoupled later.
resolve #2498 .
Implementation. Store the ‘version info’ as raw string in the files:
/PAI_CODE_ROOT/
/version
PAI.VERSION
K8S.VERSION
The format would be ‘v0.12.0’ and ‘V0.12.0-1.9.9’.
There are 4 places where would need ‘version info’: