Add Python 3.13 support #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, for my information is it the issue which is preventing the push of the version 0.9.4 on pypi.org? How could we help to allow the push of this version on pypi.org? |
Collaborator
Author
|
I'm going to tackle this issue this week. The compability issue was up in the air in CPython, but the final APIs are done. |
There was a problem hiding this comment.
Pull Request Overview
Adds support for Python 3.13 by branching on the new public PyTime API, updating compatibility aliases, and expanding CI/test configurations.
- Introduce
PyTime_Timeon ≥3.13 and fallback for older APIs inlogrecord.cxx, including a manual millisecond calculation. - Alias public
PyTime_tandPyTime_AsSecondsDoubleincompat.hxxfor ≥3.13. - Bump dependencies and extend GitHub Actions matrices to include Python 3.13; update/workflow and
pyproject.tomlaccordingly.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/picologging/logrecord.cxx | Conditional PyTime API usage and fallback msecs calculation |
| src/picologging/compat.hxx | Aliases for public PyTime types/functions on Python 3.13+ |
| pyproject.toml | Bumped scikit-build and updated cibuildwheel skip patterns |
| .github/workflows/wheel.yml | Expanded build matrix, updated triggers and cibuildwheel version |
| .github/workflows/test.yml | Added Python 3.13, updated OS filters and conditional steps |
| .github/workflows/quality.yml | Commented out the clang-tidy check |
| .github/workflows/hypothesis.yaml | Extended Hypothesis matrix with Python 3.12 and 3.13 |
Comments suppressed due to low confidence (3)
src/picologging/logrecord.cxx:173
- Add unit tests that exercise the
#elsebranch for Python ≥3.13 to verify thatmsecsis calculated correctly, ensuring this new fallback logic is covered.
// msecs conversion isn't in 3.13 API
.github/workflows/quality.yml:169
- Re-enable or update the
clang-tidystep (including correct include paths for newer Python headers) to maintain C++ linting and catch regressions.
# - name: Check clang-tidy
.github/workflows/wheel.yml:3
- [nitpick] Consider restricting the workflow triggers back to the main branch or release branches to avoid running full builds on every feature branch push.
on: [push, pull_request]
zooba
approved these changes
Jun 17, 2025
Collaborator
Author
|
related discussion python/cpython#124088 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It also seems that 3.13 doesn't have an API for getting milliseconds, so the timestamp of the log record will be to the nearest second (unless I find a solution)