Skip to content

Update search limits to avoid 500s #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lossyrob merged 2 commits into from
Dec 10, 2021
Merged

Update search limits to avoid 500s #15

lossyrob merged 2 commits into from
Dec 10, 2021

Conversation

@moradology
Copy link
Contributor

@moradology moradology commented Nov 30, 2021 •
edited
Loading

Description

This PR attempts to resolve two persistent issues:

  1. a limit of 0 should issue a 400
  2. extremely high limit values (e.g. 10000) issue a 500 based on response sizes being too large for the server

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

This has been run locally.

Checklist:

Please delete options that are not relevant.

  • I have performed a self-review
  • Changelog has been updated
  • Unit tests pass locally (./scripts/test)
  • Code is linted and styled (./scripts/format)

@lossyrob lossyrob merged commit 735df29 into microsoft:main Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lossyrob lossyrob lossyrob approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@moradology @lossyrob