Skip to content

Logging improvements #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mmcfarland merged 13 commits into from
Jan 10, 2022
Merged

Logging improvements #23

mmcfarland merged 13 commits into from
Jan 10, 2022

Conversation

@mmcfarland
Copy link
Member

@mmcfarland mmcfarland commented Jan 4, 2022 •
edited
Loading

Description

Improve trace request logging for STAC and Tiler services, including:

  • Parse collection and item ids from multiple sources: path, querystring, cql-json, cql2-json, and item-search json
  • Consolidate tracing between services
  • Create dedicated health endpoint for Tiler service
  • Ignore health check pings in request traces
  • Improvements to dev deploys by specifying image locations

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Extensive dev deploy and local testing; new unit tests.

Checklist:

Please delete options that are not relevant.

  • I have performed a self-review
  • Unit tests pass locally (./scripts/test)
  • Code is linted and styled (./scripts/format)

@mmcfarland
Add dedicated health check endpoint for pctiler
2cd85f8 
Also sets the liveness probe to use this new endpoint. Uses the same URL
path as pcstac, this will help isolate requests in the logs.
@mmcfarland
Use constants for logging service name
b607b47
@mmcfarland
Fix local volume mount
1ef88d6 
The directory is copied in the Dockerfile, so it was loading on the
container, however this typo prevented reloading of pccommon when
changes were made without rebuilding the image.
@mmcfarland
Consolidate tracing functionality
6397e83 
Rather than maintaining parity between two request tracing
implementations, create a common trace that can be used by both
projects.
@mmcfarland
Prevent request tracing on health check endpoints
d829fc5
@mmcfarland
Parse collection/item ids from search for logging
5d6a15b
@mmcfarland
Allow ACR overrides in dev deployments
57432ef 
Defaults to publish images for staging deploys
@mmcfarland
Rename for Python convention
3933782
@mmcfarland mmcfarland requested a review from lossyrob January 4, 2022 15:03
@mmcfarland
Include request ip in trace
9d65c17
@mmcfarland
Merge remote-tracking branch 'origin/main' into feature/mjm/logging-i…
2ffd07e 
…mprovements
@mmcfarland
Remove unused config
78fe50f
@mmcfarland
Use request sensitive middleware for trace logs
a73fedb 
Traditional middleware will corrupt usage of starlette request objects
by downstream route functions. Use a middleware class crafted for
accessing the request body without interfering with further processing.
@mmcfarland
Lint: formatting
d48f9a8 
Auto-formatter
@mmcfarland mmcfarland merged commit 3f767d6 into main Jan 10, 2022
@mmcfarland mmcfarland deleted the feature/mjm/logging-improvements branch January 10, 2022 21:20
@mmcfarland mmcfarland mentioned this pull request Jun 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lossyrob lossyrob lossyrob approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mmcfarland @lossyrob