Skip to content

Conversation

@TomAugspurger
Copy link
Contributor

In #201, we're adding KEDA for scaling the streaming pipelines. KEDA currently requires Kubernetes 1.24.

This updates the kind action to a version compatible with Kubernetes 1.24 and newer, and bumps the Kubernetes version we're using.

Tom Augspurger added 3 commits May 10, 2023 16:16
This bumps the version of helm/kind-action to 1.5. In
https://github.com/microsoft/planetary-computer-tasks/actions/runs/4941001231/jobs/8833187352?pr=201,
we're running into an incompatibility between the installed Kubernetes
version and the version required by KEDA:

```
===== KEDA =======
+ helm repo add kedacore https://kedacore.github.io/charts
"kedacore" has been added to your repositories
+ helm upgrade --install keda kedacore/keda -n keda --create-namespace
--wait --timeout 2m0s
Release "keda" does not exist. Installing it now.
Error: chart requires kubeVersion: >=v1.24.0-0 which is incompatible
with Kubernetes v1.23.4
Error: Process completed with exit code 1.
```
@TomAugspurger TomAugspurger marked this pull request as ready for review May 11, 2023 12:35
@TomAugspurger
Copy link
Contributor Author

That seemed to work, but I'm also going to try bumping the version of kubectl. We were getting 1.23.12

Run helm/kind-action@v1.4.0

Adding kubectl directory to PATH...
kind v0.16.0 go1.19.1 linux/amd64
Client Version: version.Info{Major:"1", Minor:"23", GitVersion:"v1.23.12", GitCommit:"c6939792865ef0f70f92006081690d77411c8ed5", GitTreeState:"clean", BuildDate:"2022-09-21T12:20:29Z", GoVersion:"go1.17.13", Compiler:"gc", Platform:"linux/amd64"}

For reference, I have 1.26.1 locally.

This reverts commit 4b83a0e.
@TomAugspurger
Copy link
Contributor Author

That one failed

kind v0.17.0 go1.19.2 linux/amd64
/opt/hostedtoolcache/kind/v0.17.0/amd64/kubectl/bin//kubectl: line 1: syntax error near unexpected token `<'
/opt/hostedtoolcache/kind/v0.17.0/amd64/kubectl/bin//kubectl: line 1: `<?xml version='1.0' encoding='UTF-8'?><Error><Code>NoSuchKey</Code><Message>The specified key does not exist.</Message><Details>No such object: kubernetes-release/release/v.1.[25](https://github.com/microsoft/planetary-computer-tasks/actions/runs/4948041273/jobs/8848235428?pr=202#step:8:26).5/bin/linux/amd64/kubectl</Details></Error>'

Reverting back to the previous commit, which passed. Hopefully that'll be good enough for #201

@TomAugspurger TomAugspurger merged commit 4c84625 into main May 11, 2023
@TomAugspurger TomAugspurger deleted the tom/fix/bump-kind-version branch May 11, 2023 14:10
@TomAugspurger
Copy link
Contributor Author

This possibly caused a failure on main: https://github.com/microsoft/planetary-computer-tasks/actions/runs/4948828133/jobs/8850096944.

 • Starting control-plane 🕹️  ...
 ✗ Starting control-plane 🕹️
ERROR: failed to create cluster: failed to init node with kubeadm: command "docker exec --privileged kind-pctasks-control-plane kubeadm init --skip-phases=preflight --config=/kind/kubeadm.conf --skip-token-print --v=6" failed with error: exit status 1

I'll investigate

TomAugspurger pushed a commit that referenced this pull request May 19, 2023
In #202 we
updated the version of Kind used in the `pr` GitHub Acvtion, to
support newer Kubernetes versions.

This makes the same change in the `cicd` action.
TomAugspurger pushed a commit that referenced this pull request May 19, 2023
In #202 we
updated the version of Kind used in the `pr` GitHub Acvtion, to
support newer Kubernetes versions.

This makes the same change in the `cicd` action.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants