Skip to content

Conversation

@chadp777
Copy link
Contributor

@chadp777 chadp777 commented Aug 13, 2025

Description

Enable bool type for template.py to prevent failures when passing in boolean args for pctasks. If we pass them in as a string, it can cause problems, so we should just treat them as bool.

Also, we increment version 0.1.5 -> 0.1.6

Fixes # (issue)
│ File "/usr/lib/python3.12/site-packages/pctasks/core/utils/template.py", line 174, in template_str ││ raise TemplateError(f"Error in template '{m.group(0)}': {e}") from e ││ pctasks.core.utils.template.TemplateError: Error in template '${{ args.force }}': Expected final value at key fo ││ time="2025-08-13T17:15:18.552Z" level=info msg="sub-process exited" argo=true error=""

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Locally and in Production with a prior local build -- looks like we forgot to actually merge this one into main.

Checklist:

Please delete options that are not relevant.

  • I have performed a self-review
  • Changelog has been updated
  • Documentation has been updated
  • Unit tests pass locally (./scripts/test)
  • Code is linted and styled (./scripts/format)

@chadp777 chadp777 requested review from ghidalgo3 and srijan55 August 13, 2025 18:30
@ghidalgo3 ghidalgo3 merged commit e093786 into main Aug 13, 2025
6 checks passed
@ghidalgo3 ghidalgo3 deleted the chadp/fix-utils-template-typing branch August 13, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants