Skip to content

fix(screencast): correct overlay/chapter channels#3303

Merged
dgozman merged 1 commit intomicrosoft:mainfrom
luisfaceira:screencast-overlay-and-chapter-bindings
May 1, 2026
Merged

fix(screencast): correct overlay/chapter channels#3303
dgozman merged 1 commit intomicrosoft:mainfrom
luisfaceira:screencast-overlay-and-chapter-bindings

Conversation

@luisfaceira
Copy link
Copy Markdown
Contributor

  • Fix screencast overlay/chapter/visibility APIs to call the screencast* channel methods expected by the driver.
  • Add regression coverage for overlay and chapter APIs.

Fixes #3302

Map overlay/chapter/visibility calls to screencastShowOverlay,
screencastRemoveOverlay, screencastChapter, and screencastSetOverlayVisible.

Adds tests that confirm the bug and the fix.

Fixes microsoft#3302
@luisfaceira
Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

Copy link
Copy Markdown
Collaborator

@dgozman dgozman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@dgozman dgozman merged commit 5012d40 into microsoft:main May 1, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Screencast chapter and overlay features have bad bindings and do not work

2 participants