[Bug]: Page.onClose is not called with browser window is closed

[davidnewcomb]

Version

1.49.0

Steps to reproduce

git clone git@github.com:davidnewcomb/playright-bug-onclose.git
cd playright-bug-onclose
mvn clean install

Expected behavior

When I close the window then Page.onClose{} should fire.

Actual behavior

Page.onClose{} is only called when I call page.close() or browserContext.close().

Additional context

I created 2 tests that run consecutively one which uses BrowserContext and one which does not use BrowserContext. Both tests never first page.onClose when I close the window or close the tab.

Environment

-Operating System: MacOS Sequioa 15.2
-CPU: intel core i9
-Browser: Nightly
-Java version: Java version: 22.0.1, vendor: Homebrew, runtime: /usr/local/Cellar/openjdk/22.0.1/libexec/openjdk.jdk/Contents/Home
-Java compiled for v 1.8 and 21
-Tested on Nightly/firefox and Chromium
-Maven: 3.9.8
-Running in: Spring Tool Suite 4 - Version: 4.26.0.RELEASE

[Drew-Ackerman]

I believe this is intentional behavior.

If we reference the browser.close() documentation, we see a note:

This is similar to force quitting the browser. Therefore, you should call BrowserContext.close() on any BrowserContext's you explicitly created earlier with Browser.newContext() before calling Browser.close().

If you want your page.onClose method to fire, you need to use browser.close or browserContext.close.

Here is where browser.close sends the close message

Here is where browserContext.close does the same

[davidnewcomb]

Demonstration for this issue moved to https://github.com/davidnewcomb/playright-bug-onclose/tree/bug_1714