chore: roll driver to 1.60.0-beta-1778180503000#1918
Merged
yury-s merged 2 commits intomicrosoft:mainfrom May 7, 2026
Merged
Conversation
pavelfeldman
approved these changes
May 7, 2026
- Plumb viewport size through screencast onFrame callback (#40649). - Generate ScreencastFrame.java from api.json by recursing into function arg Objects carrying langAliases.
ScreencastFrame represents an event payload dispatched to the client, so model it like WebSocketFrame: a top-level interface in the com.microsoft.playwright package with accessor methods, and a hidden *Impl class in the impl package. Generator-side: when an Object inside a function arg carries a langAlias, register it as a CustomInterface (rather than a CustomClass of public fields) and write it to the playwright package directory. This is a breaking change to the screencast API introduced in 1.59: frame.data -> frame.data(), and the type now lives in com.microsoft.playwright instead of com.microsoft.playwright.options.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1.60.0-alpha-1778025033000to1.60.0-beta-1778180503000.Screencast.start'sonFramecallback.ScreencastFramenow exposesviewportWidth()/viewportHeight()alongsidedata().ScreencastFramefrom a class with public fields incom.microsoft.playwright.optionsto a top-level interface incom.microsoft.playwright(with a hiddenScreencastFrameImplin theimplpackage), matching howWebSocketFrameis structured. Breaking change — acceptable since the screencast API was introduced in 1.59.ApiGeneratorto support this: function-arg Objects carrying alangAliasare now generated as interfaces (via a newCustomInterfacetype) and written to the playwright package directory instead ofoptions/.Test plan
mvn -f playwright/pom.xml test -Dtest='TestScreencast'— all 13 tests pass, including a newonFrameShouldReceiveViewportSize.