chore: roll to 1.57.0-beta-1763718928000 #3007
Merged
+639
−1,065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
approved these changes
Nov 24, 2025
| ) -> None: | ||
| await self._click(**locals_to_params(locals())) | ||
|
|
||
| async def _click( |
Member
Author
There was a problem hiding this comment.
true that! but without this separation, we'd have a frame.click(steps=) param
| def ensure_trailing_slash(url: str) -> str: | ||
| split = url.split("://", maxsplit=1) | ||
| if len(split) == 2: | ||
| # URL parser doesn't like strange/unknown schemes, so we replace it for parsing, then put it back |
Contributor
There was a problem hiding this comment.
Was this comment incorrect? Could it be python-version-specific?
Member
Author
There was a problem hiding this comment.
I'm not sure if it was incorrect. Certainly not version specific, urlparse didn't change much in the past years: https://github.com/python/cpython/blob/3.14/Lib/urllib/parse.py
The implementation definitely wasn't correct for the my.custom.protocol test cases. And I figured that instead of trying to understand its behaviour, I just implement the WHATWG spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2985